create.biols.data not working correctly

[marchtaylor]

Dear FLBEIA folks,
I am trying to recondition my FLBiols object and am having trouble with the create.biols.data function.

First, there seems to be a mistake in the help file - Rather than the list elements needing "stk.min.age" and "stk.max.age", I believe these should be named "stk.age.min" and "stk.age.max". Also, "stk_range.plusgroup" is missing.

I also believe the function has yet to be updated to the new FLBiol format. For example, several of the dimension checks call stk.fec instead of stk.fec$fec.

[AgurtzaneUrtizberea]

Dear Marc Thank you for your comments, I will take a look now and add your comments to the help file. Regards, Agurtzane De: Marc Taylor [mailto:[email protected]] Enviado el: 05 May 2017 11:27 Para: flr/FLBEIA <[email protected]> CC: Subscribed <[email protected]> Asunto: [flr/FLBEIA] create.biols.data not working correctly (#16) Dear FLBEIA folks, I am trying to recondition my FLBiols object and am having trouble with the create.biols.data function. First, there seems to be a mistake in the help file - Rather than the list elements needing "stk.min.age" and "stk.max.age", I believe these should be named "stk.age.min" and "stk.age.max". Also, "stk_range.plusgroup" is missing. I also believe the function has yet to be updated to the new FLBiol format. For example, several of the dimension checks call stk.fec instead of stk.fec$fec. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#16>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACqmMAGL_mjrFRFff-G-B-TT-O5iXj-wks5r2utjgaJpZM4NRrtI>.

[marchtaylor]

Thanks Agurtzane. I'm attempting to do my conditioning outside the function for the meantime. I've come across the following issue with FLBiol as well: flr/FLCore#35

Seems to not want to allow expanding of the @fec, @mat, and @rec dimensions to include projection years. Maybe you have experienced this issue as well.

[ssanchezAZTI]

Dear Marc, There was a mistake in the documentation. In reality, the age range is introduced with the following parameters: stk.range.min and stk.range.max, instead of "stk.min.age" and "stk.max.age". And you were right that there was also missing "stk_range.plusgroup". We already corrected all this in the documentation, so if you install the last FLBEIA version from GitHub, you will get now the correct guidance. Sorry for the mistake and thank you for making us notice it! Regards, Sonia De: Marc Taylor [mailto:[email protected]] Enviado el: viernes, 05 de mayo de 2017 11:27 Para: flr/FLBEIA CC: Subscribed Asunto: [flr/FLBEIA] create.biols.data not working correctly (#16) Dear FLBEIA folks, I am trying to recondition my FLBiols object and am having trouble with the create.biols.data function. First, there seems to be a mistake in the help file - Rather than the list elements needing "stk.min.age" and "stk.max.age", I believe these should be named "stk.age.min" and "stk.age.max". Also, "stk_range.plusgroup" is missing. I also believe the function has yet to be updated to the new FLBiol format. For example, several of the dimension checks call stk.fec instead of stk.fec$fec. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#16>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEz9kgvSrleF7bFMns0gGQxozC9599wIks5r2utjgaJpZM4NRrtI>.

[marchtaylor]

Great - fast response time here :-)

Also, I managed to find out how to replace values in the model slots of the new FLBiol format. You may need to adopt some of your code that replaces NAs: e.g. mat(biol)[is.na(mat(biol))] <- 0

[marchtaylor]

One more related issue: create.list.stks.flqa will probably need to be updated to get patterns "range.min" and "range.max" objects (instead of "age.min" and "age.max")

[ssanchezAZTI]

Dear Marc, You are right that there is an inconsistency there. We will have a look at and fix it as soon as possible. Regards, Sonia De: Marc Taylor [mailto:[email protected]] Enviado el: viernes, 05 de mayo de 2017 15:36 Para: flr/FLBEIA CC: Sonia Sanchez; Comment Asunto: Re: [flr/FLBEIA] create.biols.data not working correctly (#16) One more related issue: create.list.stks.flqa will probably need to be updated to get patterns "range.min" and "range.max" objects (instead of "age.min" and "age.max") — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#16 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEz9khT3nVfMvWI1blFTmLw6dO4ozYTWks5r2yXVgaJpZM4NRrtI>.

[AgurtzaneUrtizberea]

Dear Marc, Thanks a lot for your comments, we have fixed the problem. Now in most of the functions is not required to introduce range.min and neither range.max. The creator functions take stk.age.min and stk.age.max values to fill the values in age range. It’s only create.indices.data where you are required to introduce “stk_ind_range.min” and “stk_ind_range.max”. These changes are already updated in github. Regards, De: Marc Taylor [mailto:[email protected]] Enviado el: 05 May 2017 15:36 Para: flr/FLBEIA <[email protected]> CC: Agurtzane Urtizberea Ijurco <[email protected]>; Comment <[email protected]> Asunto: Re: [flr/FLBEIA] create.biols.data not working correctly (#16) One more related issue: create.list.stks.flqa will probably need to be updated to get patterns "range.min" and "range.max" objects (instead of "age.min" and "age.max") — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#16 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACqmMF-GcRZ_xxRnyQEP6XQRweDz5V5rks5r2yXVgaJpZM4NRrtI>.