Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Fluentd from RubyGems #379

Open
ashie opened this issue Apr 18, 2022 · 1 comment
Open

Download Fluentd from RubyGems #379

ashie opened this issue Apr 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ashie
Copy link
Member

ashie commented Apr 18, 2022

Currently Fluentd is downloaded from GitHub, not RubyGems:

if ENV["INSTALL_GEM_FROM_LOCAL_REPO"]
# During build process, pre-built fluentd gem will be installed
# from this local repository, this way is used to avoid embedding full-path
# into managed Gemfile.lock
source FLUENTD_LOCAL_GEM_REPO do
gem "fluentd"
end
else
# Lock to specific revision
git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
gem "fluentd", github: "fluent/fluentd", ref: FLUENTD_REVISION
end

But, now a day we don't bundle intermediate revision of Fluentd.
So I think using formal version of Fluentd gem is more reasonable.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 30 days

@github-actions github-actions bot added the stale label Jul 17, 2022
@ashie ashie added enhancement New feature or request and removed stale labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant