get_raw_vmfolder now fails due to blank? method being attempted against strings for type param

[Ryuzavi]

Hey

Found this issue today when trying out fog-vsphere. It appears the recent changes to get_folder has introduced an error whenever get_raw_vmfolder is called from other resources such as clone_vm or list_folders.

The specific problem is get_raw_vmfolder calls get_folder and sets the type param to 'vm':

fog-vsphere/lib/fog/vsphere/requests/compute/get_folder.rb

Lines 48 to 50 in 443aa7b

	def get_raw_vmfolder(path, datacenter_name)
	get_raw_folder(path, datacenter_name, 'vm')
	end

Passing in a string for the type param now fails as a call to the blank? method is performed as an argument check:

fog-vsphere/lib/fog/vsphere/requests/compute/get_folder.rb

Line 26 in 443aa7b

raise ArgumentError, "#{type} is unknown" if type.blank?

Problem is string in ruby doesn't have that method available so it fails accordingly:

NoMethodError: undefined method `blank?' for "vm":String

The previous version of get_folder, in 2.4.0, didn't have this issue as it specifically converted the type param to a symbol if it was detected as the string 'vm':

fog-vsphere/lib/fog/vsphere/requests/compute/get_folder.rb

Lines 10 to 14 in df58b90

	when 'vm', :vm
	# if you're a vm then grab the VM.
	folder = get_raw_vmfolder(path, datacenter_name)
	raise(Fog::Compute::Vsphere::NotFound) unless folder
	folder_attributes(folder, datacenter_name)

Cheers,
R.

[Ryuzavi]

Just noticed that there's another call to blank? elsewhere that also causes the problem but this time for the Nil class:

fog-vsphere/lib/fog/vsphere/requests/compute/vm_clone.rb

Lines 634 to 638 in 443aa7b

	unless options.key?('storage_pod')
	unless options['volumes'].blank?
	relocation_spec[:disk] = relocate_template_volumes_specs(vm_mob_ref, options['volumes'], options['datacenter'])
	end
	end

Workaround for both issues is to monkey patch the base classes to include a blank method:

class NilClass
  def blank?
    true
  end
end

class String
  def blank?
    self.strip.empty?
  end
end