From 07f343f1c25ee5c57fb9e096fbc6c27e453287c0 Mon Sep 17 00:00:00 2001 From: Matt Travi Date: Fri, 10 Jun 2022 21:02:01 -0500 Subject: [PATCH] fix(build-details): deep-merged into the package scaffolding results so scripts arent lost --- src/scaffolder/project-type/package/scaffolder-test.js | 7 ++++++- src/scaffolder/project-type/package/scaffolder.js | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/scaffolder/project-type/package/scaffolder-test.js b/src/scaffolder/project-type/package/scaffolder-test.js index 8d91f9ab..aaaeb249 100644 --- a/src/scaffolder/project-type/package/scaffolder-test.js +++ b/src/scaffolder/project-type/package/scaffolder-test.js @@ -265,6 +265,10 @@ suite('package project-type', () => { test('that the registry to publish to is defined when provided', async () => { const publishRegistry = any.url(); + const dialect = jsCore.dialects.BABEL; + buildDetails.default + .withArgs({projectRoot, projectName, packageBundlers, visibility, packageName, dialect, decisions}) + .resolves(buildDetailsResults); await scaffoldPackage({ projectRoot, @@ -277,7 +281,8 @@ suite('package project-type', () => { packageTypes, tests, publishRegistry, - dialect: jsCore.dialects.BABEL + dialect, + packageBundlers }); assert.calledWith( diff --git a/src/scaffolder/project-type/package/scaffolder.js b/src/scaffolder/project-type/package/scaffolder.js index 9c78947f..a1a93b0f 100644 --- a/src/scaffolder/project-type/package/scaffolder.js +++ b/src/scaffolder/project-type/package/scaffolder.js @@ -74,7 +74,6 @@ export default async function ({ return deepmerge.all([ { - ...detailsForBuild, documentation: scaffoldPackageDocumentation({packageName, visibility, scope, packageManager}), eslintConfigs: [], nextSteps: [ @@ -84,6 +83,7 @@ export default async function ({ scripts: {}, badges: defineBadges(packageName, visibility) }, + detailsForBuild, results ]); }