From b2b52971b37eb9099af47f5e7a57314b7afb6496 Mon Sep 17 00:00:00 2001 From: Abdelrahman Awad Date: Sat, 22 Feb 2025 16:55:48 +0200 Subject: [PATCH] fix: label for attribute should be only for form elements --- .changeset/five-planes-teach.md | 5 +++++ packages/core/src/a11y/useLabel.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/five-planes-teach.md diff --git a/.changeset/five-planes-teach.md b/.changeset/five-planes-teach.md new file mode 100644 index 00000000..789c6bed --- /dev/null +++ b/.changeset/five-planes-teach.md @@ -0,0 +1,5 @@ +--- +'@formwerk/core': patch +--- + +fix: label "for" attribute should be only for form elements diff --git a/packages/core/src/a11y/useLabel.ts b/packages/core/src/a11y/useLabel.ts index 609cd5d3..79ae1c25 100644 --- a/packages/core/src/a11y/useLabel.ts +++ b/packages/core/src/a11y/useLabel.ts @@ -17,7 +17,7 @@ export function useLabel(props: LabelProps) { return { ref: refCapture, id: `${toValue(props.for)}-l`, - for: isLabelElement(labelRef.value) ? toValue(props.for) : undefined, + for: isLabelElement(labelRef.value) && isInputElement(toValue(props.targetRef)) ? toValue(props.for) : undefined, onClick: props.handleClick || undefined, } as AriaLabelProps; });