Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B1144C not found via BLE after flashing FOSSASIA firmware: Name changed from "LSLED" to "LED Badge Magic" #56

Open
mjstahlberg opened this issue Jan 7, 2025 · 1 comment

Comments

@mjstahlberg
Copy link

This is a follow-up to #52 and possibly the same as #24.

After flashing badgemagic-firmware compiled from v0.1-12-g9cda337, the badge is now not found via BLE. Recall that in #52 with the OEM firmware, the badge was found but the connection failed.

I noticed that the BLE device name changed from LSLED to LED Badge Magic:

% badgemagic --transport ble --list-devices|grep LED
- […]: name=Some("LED Badge Magic") services=[0000fee0-0000-1000-8000-00805f9b34fb]

Changing BADGE_BLE_DEVICE_NAME from "LSLED" to "LED Badge Magic" resolves this issue and lets me upload examples/smiley.toml via BLE.

@kienvo
Copy link
Member

kienvo commented Feb 15, 2025

Let's give more control to users. At the current state, we could upload bitmap content to someone's badge accidentally, especially with the coming-up always-on BLE feature. To resolve this, I've made the device name configurable in fossasia/badgemagic-firmware#67

So let UUID and device name be decided by users as arguments, and should have defaults if the arguments are not specified to avoid complexity for new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants