Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin task-collection pip to <24.1? #1591

Closed
tcompa opened this issue Jul 1, 2024 · 2 comments · Fixed by #1675
Closed

Pin task-collection pip to <24.1? #1591

tcompa opened this issue Jul 1, 2024 · 2 comments · Fixed by #1675

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jul 1, 2024

As of pip v24.1, the scmultiplex task package cannot be installed (ref fmi-basel/gliberal-scMultipleX#106).

Note that task collection always runs pip install --upgrade pip before installing a package, which means that any task-collection of that package taking place now will likely fail, even without a version update of fractal-server.

The specific issue is related to using the 1.4 prefect version, which has some old-style metadata which are now deprecated as of pip=24.1 (see https://pip.pypa.io/en/stable/news/#deprecations-and-removals and pypa/pip#12063). I don't know whether other task packages are affected.

I have no idea of how complex it would be to fix the specific scmultiplex issue, but for the moment the only fractal-side fix is to constrain the task-collection pip to <24.1.

@tcompa
Copy link
Collaborator Author

tcompa commented Jul 3, 2024

As of the call this afternoon:
Let's cap this to <= FRACTAL_MAX_PIP_VERSION, and start with FRACTAL_MAX_PIP_VERSION=24.0

The goal is not only to fix the scmultiplex use case (which can also be fixed in other ways), but also to provide a bit more stability.

@tcompa
Copy link
Collaborator Author

tcompa commented Jul 22, 2024

This change has to happen twice, in the standard and ssh task collection

@ychiucco ychiucco mentioned this issue Jul 23, 2024
2 tasks
@ychiucco ychiucco linked a pull request Jul 23, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants