Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The population passed to callbacks is not human-readable. #5

Closed
alenl opened this issue Oct 21, 2018 · 3 comments · Fixed by #6
Closed

The population passed to callbacks is not human-readable. #5

alenl opened this issue Oct 21, 2018 · 3 comments · Fixed by #6

Comments

@alenl
Copy link
Contributor

alenl commented Oct 21, 2018

Hi @framp , thanks for building this great library!

I was playing around a bit and I found it is hard to debug the results since the population passed to callbacks (meta.pop member) is untabled. I propose a change that adds one more member (meta.popTables) where each entity is in form of a timetable. It's a very simple change and I've tested it in alenl/timetabling-solver@f970379 . Would you take a PR on it? If you are interested, I'll prepare it.

@framp
Copy link
Owner

framp commented Oct 22, 2018

Hi @alenl, glad you're liking the library!

I think it can work out, if it's behind a debug flag: some of the places where this function is being used are already quite slow and I wouldn't want to add another bookables * populationElements loop on top of it

@alenl
Copy link
Contributor Author

alenl commented Oct 23, 2018

Sure thing, I'll add that and make a PR.
Are you interested in other PRs?

@framp
Copy link
Owner

framp commented Oct 23, 2018

Really appreciated!

There are a couple optimisation/improvements here:
#1

Also open to ideas and to discuss what more can we add / improve
(the original idea was to provide solvers for other timetabling problems as well, not only mininum collisions but I never had the actual need for it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants