A few linux behavior changes #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Call the timer register in a deferred callback launched from init 2. implementsGui has a `canUseTimerSupport` check
jatinchowdhury18
approved these changes
Jun 23, 2022
| defineAudioPorts(); | ||
|
|
||
| haveCompletedDeferredInit = false; | ||
| _host.requestCallback(); |
There was a problem hiding this comment.
Just to make sure I'm understanding correctly: The idea is that if init() is called on a thread that isn't the main thread, defer the timer initialization to a main thread callback?
There was a problem hiding this comment.
A bit different. The idea is that in init the host doesn’t know if a plugin supports timers. So it’s not clear that we can call rather than just probe extensions. See free-audio/clap#111 (reply in thread)
src/wrapper/clap-juce-wrapper.cpp
Outdated
| #if JUCE_LINUX | ||
| if (_host.canUseTimerSupport()) | ||
| { | ||
| _host.timerSupportRegister(1000 / 50, &idleTimer); |
There was a problem hiding this comment.
Is there a reason for the number 1000 / 50?
There was a problem hiding this comment.
50 times a second seemed ok. I guess I could change it to 60 to be 60hz and will do so
baconpaul
added a commit
to baconpaul/clap-juce-extensions
that referenced
this pull request
Jun 23, 2022
This reverts commit d4c2c05. For some reason in bws43b8 it causes a segv on macos
baconpaul
added a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes which only impact the Linux implementation
init
canUseTimerSupportcheckCloses #63