Outstanding build reproducibility issues

[emaste]

#2410 addressed many sources of non-reproducibility, and reproducible-builds.org's CI now reports 535 (99.4%) out of 538 FreeBSD files were reproducible in our test setup.

The three outstanding failures are:

• https://tests.reproducible-builds.org/freebsd/dbd/repo/FreeBSD:15:amd64/current/data.pkg.html
• https://tests.reproducible-builds.org/freebsd/dbd/repo/FreeBSD:15:amd64/current/packagesite.pkg.html
• https://tests.reproducible-builds.org/freebsd/dbd/repo/FreeBSD:15:amd64/current/FreeBSD-runtime-current.pkg.html

These are data structure ordering issues

[emaste]

(screenshots as the links will update to the latest results)

[bapt]

are you sure this was created with pkg 2.0.6

[emaste]

Reproducible CI folks confirmed it is

[emaste]

"deps" are processed like this:

        dbg(4, "Emitting deps");
        map = NULL;
        while (pkg_deps(pkg, &dep) == EPKG_OK) {
                submap = ucl_object_typed_new(UCL_OBJECT);
                MANIFEST_EXPORT_FIELD(submap, dep, origin, string);
                MANIFEST_EXPORT_FIELD(submap, dep, version, string);
                if (map == NULL) 
                        map = ucl_object_typed_new(UCL_OBJECT);
                ucl_object_insert_key(map, submap, dep->name, 0, false);
        }
        if (map)
                ucl_object_insert_key(top, map, "deps", 4, false);

Are we sure ucl will produce stable output (from the ucl_object_insert_keys)?

[emaste]

From IRC discussion @ifreund will take a look

[emaste]

In the most recent run, r-b.org's CI reports "538 (100.0%) out of 538 FreeBSD files were reproducible in our test setup !"
https://tests.reproducible-builds.org/freebsd/freebsd.html

I don't believe pkg has changed from the last run, so there may be something intermittent here. We'll keep an eye on this.