Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor guidelines should suggest communication first, not last #16

Open
rmol opened this issue Dec 24, 2020 · 1 comment
Open

Contributor guidelines should suggest communication first, not last #16

rmol opened this issue Dec 24, 2020 · 1 comment

Comments

@rmol
Copy link
Contributor

rmol commented Dec 24, 2020

Description

In the contributor guidelines, we wait until the very end of the document to suggest that an issue be filed before starting a PR. (Our top priority, apparently, is signing commits. 😆)

We should ask contributors to check in with us before starting, particularly if the change will be large or hasn't been captured in an issue, to ensure they're spending their time on work that's likely to be readily accepted. It's discouraging to have PRs rejected, or even just deferred so long that they require a lot of rebasing or refactoring to keep ready to merge.

@eloquence
Copy link
Member

@rmol I've put some more emphasis on communication in the contributor guide, in this section: https://docs.securedrop.org/en/latest/development/contributing.html#preparing-and-submitting-changes

The guide also mentions the code of conduct early on, now.

Do you feel that those changes are sufficient to resolve this issue, or would you like to see additional emphasis in other places?

@legoktm legoktm transferred this issue from freedomofpress/securedrop Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants