Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin-cli to authenticate with credentials #53

Closed
Fristi opened this issue Aug 26, 2019 · 1 comment
Closed

Allow admin-cli to authenticate with credentials #53

Fristi opened this issue Aug 26, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Fristi
Copy link
Contributor

Fristi commented Aug 26, 2019

Hi!

Thanks for this great library, I was writing a client myself but this one is way more complete. I would be interested in contributing if there is overlap in our needs :-)

In my previous client I used credentials to authenticate with the master admin-cli client. The reason for that is because the importing of a realm-export can only be done to a new realm. So if you want to override settings for the master realm, you cannot do this automated (I couldn't find it atleast).

I think making KeycloakConfig.Auth an ADT which has two members Secret and Credentials which will be used in the TokenManager to exchange a token the way to go? What do you think?

Greets,

Mark

@Executioner1939 Executioner1939 added the enhancement New feature or request label Aug 26, 2019
@lmuller90
Copy link
Contributor

Hey Mark!

Appreciate the feedback, admittedly the methods we have of authenticating with the master admin-cli client is rather restrictive at the moment. Looking into expanding it with your suggestion in mind, will tag you into the PR when it's up so you can confirm if our solution suits your needs.

Regards,
Louis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants