Run tests against installed rgbds, not on built binaries

[avivace]

In the CI we're setting up to package for Debian, we need to run the tests against the installed package, not on the built executable, so "run-tests.sh" fails because it checks for the compiled binaries in the parent directory (

rgbds/test/run-tests.sh

Line 38 in 727c1f5

# Refuse to run if RGBDS isn't present

)

We could add a flag that runs "run-tests" expecting the executables to be found in the path, without checking for the built binaries..

cc @robbi-blechdose

[pinobatch]

test_downstream() in tests/run-tests.sh passes a Make variable RGBDS to the repositories that it builds. This points to the prefix of the RGBDS build under test. So we'd need a variable that defaults to "$(realpath ..)" but which a caller can override. For example, to test installed RGBDS, the caller would override it with something like "$(dirname "$(command -v rgbasm)")". Should this variable be passed to tests/run-tests.sh as a command-line option or as an environment variable?

[Rangi42]

I'd go with a CLI option: run-tests.sh --rgbds ../path/.

[robbi-blechdose]

I believe neither of those is necessary.
The makefiles default to the rgbds installation in PATH, meaning a simple switch to disable the RGBDS variable assignment should do the trick.

[Rangi42]

I was going to suggest "just do cp $(which rgb{asm,link,fix,gfx}) . and then run the tests normally", but then saw that your rgbds-tests script has a line very similar to that already commented out (#cp build/src/rgbasm build/src/rgblink build/src/rgbfix build/src/rgbgfx .) Why, did it not work, or did the Debian maintainers say not to?

[robbi-blechdose]

This was part of an older test script (and I should honestly remove it).
I'd like to test against the system installation and not copied binaries for the most accurate results.