refactor constants.py with separate classes and Enums for readability

Author: geoffm39

ball.py

@@ -2,26 +2,26 @@
 from random import randint
 
 from constants import (
-    BALL_START_POSITION, VERTICAL_SURFACE, HORIZONTAL_SURFACE, BALL_COLOR, BALL_SHAPE, BALL_RADIUS,
-    NORTH, SOUTH, EAST, WEST, COMPLETE_ANGLE, MIN_PADDLE_ANGLE, MAX_PADDLE_ANGLE, DEFAULT_BALL_SPEED, RED
+    BallAttributes, VERTICAL_SURFACE, HORIZONTAL_SURFACE,
+    NORTH, SOUTH, EAST, WEST, COMPLETE_ANGLE, PaddleAttributes, Color
 )
 
 
 class Ball(RawTurtle):
     def __init__(self, canvas, **kwargs):
         super().__init__(canvas, **kwargs)
 
-        self.move_speed = DEFAULT_BALL_SPEED
+        self.move_speed = BallAttributes.DEFAULT_SPEED
         self.fireball = False
         self.latest_barrier_hit = None
 
         self.set_default_ball()
 
     def set_default_ball(self):
         self.penup()
-        self.color(BALL_COLOR)
-        self.shape(BALL_SHAPE)
-        self.setposition(BALL_START_POSITION)
+        self.color(BallAttributes.COLOR)
+        self.shape(BallAttributes.SHAPE)
+        self.setposition(BallAttributes.START_POSITION)
         self.set_random_starting_direction()
         self.hideturtle()
 
@@ -36,7 +36,8 @@ def move(self):
 
     def get_bbox(self):
         ball_x, ball_y = self.xcor(), self.ycor()
-        return ball_x - BALL_RADIUS, ball_y + BALL_RADIUS, ball_x + BALL_RADIUS, ball_y - BALL_RADIUS
+        ball_radius = BallAttributes.RADIUS
+        return ball_x - ball_radius, ball_y + ball_radius, ball_x + ball_radius, ball_y - ball_radius
 
     def get_location(self):
         ball_x, ball_y = self.xcor(), self.ycor()
@@ -76,7 +77,7 @@ def clear_latest_barrier_hit(self):
 
     @staticmethod
     def clamp_angle_to_reflection_range(angle):
-        return max(min(angle, MAX_PADDLE_ANGLE), MIN_PADDLE_ANGLE)
+        return max(min(angle, PaddleAttributes.MAX_ANGLE), PaddleAttributes.MIN_ANGLE)
 
     @staticmethod
     def is_moving_vertically(direction):
@@ -167,11 +168,11 @@ def set_speed(self, speed):
         self.move_speed = speed
 
     def reset_speed(self):
-        self.move_speed = DEFAULT_BALL_SPEED
+        self.move_speed = BallAttributes.DEFAULT_SPEED
 
     def activate_fireball(self):
         self.fireball = True
-        self.color(RED)
+        self.color(Color.RED.value)
 
     def is_fireball(self):
         return self.fireball

brick.py

@@ -1,9 +1,6 @@
 from turtle import RawTurtle
 
-from constants import (
-    TYPE, BRICK_COLOR, BRICK_SHAPE,
-    BRICK_WIDTH, BRICK_LENGTH, BrickType, NORMAL_BRICK_SCORE, BROKEN_BRICK_SCORE, STRONG_BRICK_SCORE
-)
+from constants import TYPE, BRICK_COLOR, BrickAttributes, BrickType
 
 
 class Brick(RawTurtle):
@@ -20,19 +17,19 @@ def __init__(self, canvas, brick_attributes: dict, **kwargs):
 
     def set_properties(self):
         self.penup()
-        self.shape(BRICK_SHAPE)
-        self.shapesize(stretch_len=BRICK_LENGTH)
-        self.brick_length = BRICK_WIDTH * BRICK_LENGTH
+        self.shape(BrickAttributes.SHAPE)
+        self.shapesize(stretch_len=BrickAttributes.LENGTH)
+        self.brick_length = BrickAttributes.WIDTH * BrickAttributes.LENGTH
         self.color(self.brick_color)
         self.hideturtle()
 
     def set_score(self):
         if self.is_normal():
-            return NORMAL_BRICK_SCORE
+            return BrickAttributes.NORMAL_SCORE
         elif self.is_broken():
-            return BROKEN_BRICK_SCORE
+            return BrickAttributes.BROKEN_SCORE
         elif self.is_strong():
-            return STRONG_BRICK_SCORE
+            return BrickAttributes.STRONG_SCORE
         else:
             return 0
 
@@ -41,7 +38,7 @@ def get_score(self):
 
     def set_location(self, brick_left_x, brick_top_y):
         brick_x = brick_left_x + self.brick_length / 2
-        brick_y = brick_top_y - BRICK_WIDTH / 2
+        brick_y = brick_top_y - BrickAttributes.WIDTH / 2
         self.brick_location = (brick_x, brick_y)
         self.setposition(self.brick_location)
 
@@ -58,8 +55,8 @@ def get_bbox(self):
         brick_x, brick_y = self.brick_location
         brick_left_x = brick_x - self.brick_length / 2
         brick_right_x = brick_x + self.brick_length / 2
-        brick_top_y = brick_y + BRICK_WIDTH / 2
-        brick_bottom_y = brick_y - BRICK_WIDTH / 2
+        brick_top_y = brick_y + BrickAttributes.WIDTH / 2
+        brick_bottom_y = brick_y - BrickAttributes.WIDTH / 2
         return brick_left_x, brick_top_y, brick_right_x, brick_bottom_y
 
     def get_type(self):

constants.py

@@ -25,91 +25,46 @@
 LIVES_IMAGE_Y_COORD = (SCREEN_TOP_EDGE + 26) * -1
 SCORE_POSITION = (0, SCREEN_HEIGHT / 2 - 50)
 HIGHSCORE_POSITION = (SCREEN_LEFT_EDGE + 50, SCREEN_HEIGHT / 2 - 50)
+GAME_FONT = ('Courier', 32, 'bold')
+
 STARTING_LIVES = 3
 MAX_LIVES = 5
-GAME_FONT = ('Courier', 32, 'bold')
-NORMAL_BRICK_SCORE = 10
-BROKEN_BRICK_SCORE = 30
-STRONG_BRICK_SCORE = 50
-
-PADDLE_WIDTH = 20
-DEFAULT_PADDLE_LENGTH = 5
-MIN_PADDLE_ANGLE = 15
-MAX_PADDLE_ANGLE = 165
-PADDLE_COLOR = 'yellow'
-PADDLE_LASER_COLOR = 'red'
-PADDLE_SHAPE = 'square'
-PADDLE_START_POSITION = (0, SCREEN_BOTTOM_EDGE + PADDLE_WIDTH)
-
-BALL_ANIMATION_SPEED = 50
-DEFAULT_BALL_SPEED = 1
-BALL_SIZE = 20
-BALL_RADIUS = BALL_SIZE / 2
-BALL_COLOR = 'white'
-BALL_SHAPE = 'circle'
-BALL_START_POSITION = (0, SCREEN_BOTTOM_EDGE + PADDLE_WIDTH + BALL_SIZE)
 
 SPACING = 'spacing'
 SPACE_SIZE = 'space_size'
-
 TYPE = 'type'
-NORMAL = 'normal'
-STRONG = 'strong'
-BROKEN = 'broken'
-BARRIER = 'barrier'
-
+BRICK_COLOR = 'brick_color'
+VERTICAL_SURFACE = 'vertical'
+HORIZONTAL_SURFACE = 'horizontal'
 
-class BrickType(Enum):
-    NORMAL = 'normal'
-    STRONG = 'strong'
-    BROKEN = 'broken'
-    BARRIER = 'barrier'
+EAST = 0
+NORTH = 90
+WEST = 180
+SOUTH = 270
+COMPLETE_ANGLE = 360
 
 
-class BrickColor(Enum):
+class Color(Enum):
     BLUE = 'blue'
     RED = 'red'
     YELLOW = 'yellow'
     ORANGE = 'orange'
     GREEN = 'green'
     PURPLE = 'purple'
+    WHITE = 'white'
 
 
-BRICK_COLOR = 'brick_color'
-BLUE = 'blue'
-RED = 'red'
-YELLOW = 'yellow'
-ORANGE = 'orange'
-GREEN = 'green'
-PURPLE = 'purple'
-
-BRICK_SHAPE = 'square'
-BRICK_WIDTH = 20
-BRICK_LENGTH = 3
-
-BRICK_SPACING = 5
-
-VERTICAL_SURFACE = 'vertical'
-HORIZONTAL_SURFACE = 'horizontal'
-EAST = 0
-NORTH = 90
-WEST = 180
-SOUTH = 270
-COMPLETE_ANGLE = 360
+class Shape(Enum):
+    SQUARE = 'square'
+    CIRCLE = 'circle'
+    ARROW = 'arrow'
 
-POWERUP_SHAPE = 'arrow'
-POWERUP_COLOR = 'white'
-POWERUP_SPEED = 1.5
-POWERUP_WIDTH = 20
-POWERUP_IMAGE_TIME_LIMIT = 750
-POWERUP_IMAGE_SPEED = -1
 
-LASER_SHAPE = 'arrow'
-LASER_COLOR = 'white'
-LASER_SPEED = 1.5
-LASER_WIDTH = 20
-LASER_TIME_LIMIT = 20000
-LASER_FREQUENCY = 2000
+class BrickType(Enum):
+    NORMAL = 'normal'
+    STRONG = 'strong'
+    BROKEN = 'broken'
+    BARRIER = 'barrier'
 
 
 class PowerupType(Enum):
@@ -121,3 +76,52 @@ class PowerupType(Enum):
     SMALL_PADDLE = 'small_paddle'
     BIG_PADDLE = 'big_paddle'
     EXTRA_LIFE = 'extra_life'
+
+
+class BrickAttributes:
+    SHAPE = Shape.SQUARE.value
+    WIDTH = 20
+    LENGTH = 3
+    SPACING = 5
+    NORMAL_SCORE = 10
+    BROKEN_SCORE = 30
+    STRONG_SCORE = 50
+
+
+class PaddleAttributes:
+    WIDTH = 20
+    DEFAULT_LENGTH = 5
+    MIN_ANGLE = 15
+    MAX_ANGLE = 165
+    COLOR = Color.YELLOW.value
+    LASER_PADDLE_COLOR = Color.RED.value
+    SHAPE = Shape.SQUARE.value
+    START_POSITION = (0, SCREEN_BOTTOM_EDGE + WIDTH)
+
+
+class BallAttributes:
+    ANIMATION_SPEED = 50
+    DEFAULT_SPEED = 1
+    SIZE = 20
+    RADIUS = SIZE / 2
+    COLOR = Color.WHITE.value
+    SHAPE = Shape.CIRCLE.value
+    START_POSITION = (0, SCREEN_BOTTOM_EDGE + PaddleAttributes.WIDTH + SIZE)
+
+
+class PowerupAttributes:
+    SHAPE = Shape.ARROW.value
+    COLOR = Color.YELLOW.value
+    SPEED = 1.5
+    WIDTH = 20
+    IMAGE_TIME_LIMIT = 750
+    IMAGE_SPEED = -1
+
+
+class LaserAttributes:
+    SHAPE = Shape.ARROW.value
+    COLOR = Color.ORANGE.value
+    SPEED = 1.5
+    WIDTH = 20
+    TIME_LIMIT = 20000
+    FREQUENCY = 2000