-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appmap_dir config param in appmap.yml does not work #345
Comments
Hi, the Where do you want the AppMaps to go, and what is the purpose? Sharing that information will help us to assess the best course of action. |
I guess it sort of defeats the point to have an 'advisory' about where the files will be written when they'll only be written one place. I'm attempting to create OpenApi files by running an AppMap for Mastodon. The problem is that Mastodon already uses the tmp folder and periodically will clear the folder, often while in the middle of generating an appmap. So I need to write it to a non 'tmp' folder location. |
This is true for Ruby but the other tools support Java, Python, and Node.js as well. They all provide appmap_dir in appmap.yml. Other tunable settings in the Ruby agent (use environment variables](https://appmap.io/docs/reference/appmap-ruby.html#advanced-runtime-options). So I'd suggest this is the best path forward to make the appmap dir configurable. |
Exactly, take Java for instance. It pretty clearly states that And even in the AppMap Ruby documentation under Configuration it says this first:
^That suggests pretty strongly that appmap is receiving configuration from appmap.yml, and if it did use that directory during recording, it would match the Java behavior.
That would be fine, too, there just isn't an ENV for that for Ruby to set any alternate output directory. |
🎉 This issue has been resolved in version 0.103.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
You cannot override the output directory because it's harcoded.
appmap-ruby/lib/appmap/middleware/remote_recording.rb
Line 106 in d99db94
We should be able to set
appmap_dir
to something other thantmp/appmap
but at this point in time it does not seem to be referencing the parameter during recording.The text was updated successfully, but these errors were encountered: