Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the normalized route at the end of the request #360

Open
dividedmind opened this issue Apr 30, 2024 · 0 comments
Open

Resolve the normalized route at the end of the request #360

dividedmind opened this issue Apr 30, 2024 · 0 comments

Comments

@dividedmind
Copy link
Contributor

We currently try to resolve the normalized route when the request comes in instead of when it's finished. In some environments this can be problematic; eg. devise provides route constraints that rely on certain request environment fields being filled by a middleware that only runs late in the stack (cf. issue #358).

If we move the normalized route resolution to the request finalizer we can be reasonably certain that all prerequisites are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant