Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hyde theme] Source code line numbers broken #154

Closed
hartwork opened this issue May 17, 2018 · 4 comments
Closed

[hyde theme] Source code line numbers broken #154

hartwork opened this issue May 17, 2018 · 4 comments
Assignees

Comments

@hartwork
Copy link
Contributor

Related to #153. Source code rendering, especially the line numbers are way off with the (otherwise very appealing) hyde theme. This is recent Firefox, same in recent Chromium:

nikola__hyde_theme__source_code

@ralsina ralsina self-assigned this May 18, 2018
@ralsina
Copy link
Member

ralsina commented May 18, 2018

The problem is that those are getting white-space: pre-wrap instead of pre so it's probably an easy fix. Looking...

@ralsina
Copy link
Member

ralsina commented May 18, 2018

One line fix in def2052

@ralsina ralsina closed this as completed May 18, 2018
@hartwork
Copy link
Contributor Author

Awesome!

Now that the most off thing is fixed, i notice how the source code listing is has horizontal space at places where it doesnot add to beauty but makes the listing a lot wider than the rest of the article. I'm not suggesting to make it too short, but maybe reduce whitespace a bit and even widen the page to get them back together? Here's a picture:

nikola__hyde_theme__source_code_2

Happy to make a new ticket instead, as needed.

@ralsina
Copy link
Member

ralsina commented May 18, 2018

Sure, why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants