Expose *gin.Context to AllowOriginFunc #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 3 3
Lines 172 172
=======================================
Hits 160 160
Misses 11 11
Partials 1 1
Continue to review full report at Codecov.
|
|
Can we have this shipped soon, please? |
|
I'm curious about this... I believe that this functionality is a potentially dangerous misfeature. What are actual use cases? What kind of information about the request do you need? Note that none of the test cases currently illustrate how this functionality would be useful for... |
|
move to #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users of AllowOriginFunc to have custom origin allowance logic based on request data or things stashed in
gin.Context(in my case an other middleware is stashing allowed origins usinggin.Context.Set).Fixes #64