Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fail with PR have no description #302

Open
HatsuneMiku3939 opened this issue Aug 17, 2021 · 1 comment
Open

Always fail with PR have no description #302

HatsuneMiku3939 opened this issue Aug 17, 2021 · 1 comment

Comments

@HatsuneMiku3939
Copy link

HatsuneMiku3939 commented Aug 17, 2021

lib/src/Gren.js#L1024

const matches = pr.body.match(re);

If PR have no description, this line always fail.

Getting all merged pull requestsTypeError: Cannot read property 'match' of null
    at _context17.t1 (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1760:59)
    at Array.map (<anonymous>)
    at Gren._callee17$ (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/dist/Gren.js:1773:77)
    at tryCatch (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.<computed> [as next] (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /home/filepang/.nvm/versions/node/v12.18.2/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
@MrHinsh
Copy link

MrHinsh commented Jul 9, 2024

I have a realted issue #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants