Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with pnpm in subdirectory (tries both npm and pnpm resolution?) #679

Closed
halostatue opened this issue Sep 15, 2023 · 1 comment
Closed
Labels
stale Older issue or PR without additional information, questions, or request for actions

Comments

@halostatue
Copy link

I maintain a repo that has three implementations of the same specification in it and I’m exploring licensed. This can be seen at KineticCafe/app_identity@licensed. I don't have licensed in any gem files or anything else right at the moment, so it assumes that licensed is installed globally.

The .licensed.yml requires some odd configuration for pnpm with name specified. If I do not specify name, then license status --sources pnpm works perfectly.

allowed:
  - apache-2.0
  - 0bsd
  - bsd-2-clause
  - bsd-3-clause
  - mit
  - isc

reviewed:
  mix:
    - file_system # WTFPL

apps:
  - source_path: elixir
  - source_path: ruby
  - source_path: ts

If I specify name, I get a lot of errors for npm and none for pnpm unless I modify the configuration to include sources: { npm: false, pnpm: true } for the ts/ app:

name: app_identity

allowed:
  - apache-2.0
  - 0bsd
  - bsd-2-clause
  - bsd-3-clause
  - mit
  - isc

reviewed:
  mix:
    - file_system # WTFPL

apps:
  - source_path: elixir
  - source_path: ruby
  - source_path: ts
    sources:
      npm: false
      pnpm: true

It appears that with both name and apps, somehow both npm and pnpm are enabled.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Older issue or PR without additional information, questions, or request for actions label Feb 20, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Older issue or PR without additional information, questions, or request for actions
Development

No branches or pull requests

1 participant