Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: automate consequences of go.mod go directive maintenance #72774

Open
findleyr opened this issue Mar 10, 2025 · 2 comments
Open

x/build: automate consequences of go.mod go directive maintenance #72774

findleyr opened this issue Mar 10, 2025 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@findleyr
Copy link
Member

findleyr commented Mar 10, 2025

Recently, we started automating go.mod go directives for x/ repos (#69095).

However, some x/ repos have deployments that target a certain go version, which may be incompatible with the upgraded go.mod file.

Off the top of my head, at least:

I think the x/ repo automation should include updates to target deployment versions.
Where possible, we should parameterize these deployments, so that this automation doesn't require complicated edits.

CC @dmitshur @jba

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 10, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 10, 2025
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 10, 2025
@dmitshur
Copy link
Contributor

dmitshur commented Mar 10, 2025

We can add tasks that run after the go directive maintenance happens as part of the major Go release relui workflow, here: https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go;l=552-555;drc=b7066079957dd7cad5084b68444c3fc8d30bf63e. (If there's a different timeline that's better for the needs of a given deployment, that's of course fine too.)

To use x/website's golangorg deployment as an example of what can be done, since I'm pretty familiar with it: it's an App Engine app with automatic deploys, so its maintenance CLs are predictable one-line changes like this one and don't need follow up steps as long as the deployment doesn't produce errors.

However, it does require that App Engine has the runtime being switched to; something that's easy to check manually. Not sure if it's worth automating the check; we can instead assume it'll always be there in time.

Some of the smaller App Engine apps also in x/website can also be updated, as done in CLs like this one, but since its deploys are manual, automating only the CL part of it wouldn't be a complete solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

4 participants