Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/closure-compiler-npm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v20230802.0.0
Choose a base ref
...
head repository: google/closure-compiler-npm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
7 contributors

Commits on Jul 11, 2023

  1. Bump semver from 5.6.0 to 5.7.2 

    Bumps [semver](https://github.com/npm/node-semver) from 5.6.0 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.6.0...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Jul 11, 2023
    Copy the full SHA
    6943d12 View commit details

Commits on Aug 17, 2023

  1. Merge pull request #294 from google/dependabot/npm_and_yarn/semver-5.7.2 

    Bump semver from 5.6.0 to 5.7.2
    @ChadKillingsworth
    ChadKillingsworth authored Aug 17, 2023
    Copy the full SHA
    4c0c5b7 View commit details

Commits on Oct 5, 2023

  1. Update build.yml 

    Skip publishing nightly packages for now
    @blickly
    blickly authored Oct 5, 2023
    Copy the full SHA
    e2187dc View commit details

Commits on Oct 10, 2023

  1. Bump fsevents from 1.2.9 to 1.2.13 

    Bumps [fsevents](https://github.com/fsevents/fsevents) from 1.2.9 to 1.2.13.
- [Release notes](https://github.com/fsevents/fsevents/releases)
- [Commits](fsevents/fsevents@v1.2.9...v1.2.13)

---
updated-dependencies:
- dependency-name: fsevents
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Oct 10, 2023
    Copy the full SHA
    7f5e726 View commit details

Commits on Oct 11, 2023

  1. Merge pull request #295 from google/dependabot/npm_and_yarn/fsevents-… 

    …1.2.13

Bump fsevents from 1.2.9 to 1.2.13
    @ChadKillingsworth
    ChadKillingsworth authored Oct 11, 2023
    Copy the full SHA
    a957734 View commit details

Commits on Nov 13, 2023

  1. v20231112.0.0

    Github Bot committed Nov 13, 2023
    Copy the full SHA
    f5f4410 View commit details

Commits on Jan 2, 2024

  1. Update dependencies to address security finding

    @ChadKillingsworth
    ChadKillingsworth committed Jan 2, 2024
    Copy the full SHA
    f14a108 View commit details

Commits on Jan 10, 2024

  1. Merge pull request #297 from google/update-deps 

    Update dependencies to address security finding
    @blickly
    blickly authored Jan 10, 2024
    Copy the full SHA
    d46e70d View commit details

  2. Bump debug from 3.2.6 to 3.2.7 

    Bumps [debug](https://github.com/debug-js/debug) from 3.2.6 to 3.2.7.
- [Release notes](https://github.com/debug-js/debug/releases)
- [Commits](debug-js/debug@3.2.6...3.2.7)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Jan 10, 2024
    Copy the full SHA
    e451fb5 View commit details

  3. Merge pull request #298 from google/dependabot/npm_and_yarn/debug-3.2.7 

    Bump debug from 3.2.6 to 3.2.7
    @ChadKillingsworth
    ChadKillingsworth authored Jan 10, 2024
    Copy the full SHA
    7299290 View commit details

Commits on Feb 5, 2024

  1. Turn nightly builds back on 

    These were turned off in e2187dc
    @blickly
    blickly authored Feb 5, 2024
    Copy the full SHA
    a016747 View commit details

Commits on Feb 14, 2024

  1. Merge pull request #300 from google/fix_nightly 

    Turn nightly builds back on
    @brad4d
    brad4d authored Feb 14, 2024
    Copy the full SHA
    312372c View commit details

Commits on Feb 27, 2024

  1. Bump es5-ext from 0.10.46 to 0.10.63 

    Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.46 to 0.10.63.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.46...v0.10.63)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Feb 27, 2024
    Copy the full SHA
    7365339 View commit details

Commits on Feb 28, 2024

  1. Merge pull request #304 from google/dependabot/npm_and_yarn/es5-ext-0… 

    ….10.63

Bump es5-ext from 0.10.46 to 0.10.63
    @lauraharker
    lauraharker authored Feb 28, 2024
    Copy the full SHA
    29cd805 View commit details

Commits on Mar 19, 2024

  1. v20240317.0.0

    Github Bot committed Mar 19, 2024
    Copy the full SHA
    d544892 View commit details

Commits on Apr 3, 2024

  1. Update github actions versions

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    08d9bae View commit details

  2. Update more action versions

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    dc3f27a View commit details

  3. Add included resource logging 

    Help determine what is increasing the image size
    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    c368a18 View commit details

  4. Disable service loader for graal builds

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    bfcc4df View commit details

  5. Fix color flag syntax

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    af8ad1b View commit details

  6. Try 3 for color flag

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    bd9ef52 View commit details

  7. Remove color option entirely for now

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    b0be932 View commit details

  8. Remove resource logging flags

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    a75abf7 View commit details

  9. Update java and graal versions to 21

    @ChadKillingsworth
    ChadKillingsworth committed Apr 3, 2024
    Copy the full SHA
    3589edf View commit details

  10. Merge pull request #305 from google/update-actions 

    Update github actions versions
    @concavelenz
    concavelenz authored Apr 3, 2024
    Copy the full SHA
    02d895e View commit details

Commits on Apr 20, 2024

  1. Fix windows builds 

    Broken due to NodeJS breaking change for security
    @ChadKillingsworth
    ChadKillingsworth committed Apr 20, 2024
    Copy the full SHA
    9d49e73 View commit details

  2. Merge pull request #307 from google/windows-build-spawn 

    Fix windows builds
    @ChadKillingsworth
    ChadKillingsworth authored Apr 20, 2024
    Copy the full SHA
    86be413 View commit details

Commits on Nov 20, 2024

  1. Bump cross-spawn from 7.0.3 to 7.0.6 in the npm_and_yarn group 

    Bumps the npm_and_yarn group with 1 update: [cross-spawn](https://github.com/moxystudio/node-cross-spawn).


Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Nov 20, 2024
    Copy the full SHA
    14fcb08 View commit details

Commits on Nov 25, 2024

  1. Merge pull request #311 from google/dependabot/npm_and_yarn/npm_and_y… 

    …arn-0189ad7b96

Bump cross-spawn from 7.0.3 to 7.0.6 in the npm_and_yarn group
    @blickly
    blickly authored Nov 25, 2024
    Copy the full SHA
    04149a5 View commit details

Commits on Dec 27, 2024

  1. Unset ANDROID_HOME in workflow to fix Android SDK loading error 

    A similar fix was needed for closure-compiler:

google/closure-compiler#4206
    @brad4d
    brad4d authored Dec 27, 2024
    Copy the full SHA
    da8b132 View commit details
114 changes: 61 additions & 53 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
@@ -20,15 +20,22 @@ jobs:
FORCE_COLOR: '1'
steps:
- name: Setup Java
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt-hotspot
java-version: 17
java-version: 21
java-package: jdk
architecture: x64
- name: Setup Bazelisk
uses: bazelbuild/setup-bazelisk@v2
- uses: actions/checkout@v3
uses: bazel-contrib/setup-bazel@0.8.1
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}
# Share repository cache between workflows.
repository-cache: true
- uses: actions/checkout@v4
with:
submodules: recursive
- name: Fetch submodule tags
@@ -44,7 +51,7 @@ jobs:
- name: Get yarn cache directory path
run: echo "yarn_cache_dir=$(yarn cache dir)" >> $GITHUB_ENV
- name: Yarn and maven cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
${{ env.yarn_cache_dir }}
@@ -53,16 +60,17 @@ jobs:
- name: Install packages
run: yarn install --colors=always
- name: Build jar
run: ./build-scripts/build_compiler.js
# unset ANDROID_HOME to prevent bazel from trying to use the Android SDK
run: unset ANDROID_HOME && ./build-scripts/build_compiler.js
- name: Tests
run: node_modules/.bin/mocha --colors
- name: Upload contrib folder
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Contrib folder
path: compiler/contrib
- name: Upload compiler jar
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Compiler.jar
path: packages/google-closure-compiler-java/compiler.jar
@@ -75,47 +83,47 @@ jobs:
needs: build-compiler
runs-on: ubuntu-20.04
env:
NODE_VERSION: '14.x'
NODE_VERSION: '18.x'
FORCE_COLOR: '1'
steps:
- name: Setup Java
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt-hotspot
java-version: 17
java-version: 21
java-package: jdk
architecture: x64
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- uses: graalvm/setup-graalvm@v1
with:
version: '22.3.2'
java-version: '17'
components: 'native-image'
java-version: 21
distribution: 'graalvm-community'
github-token: ${{ secrets.GITHUB_TOKEN }}
native-image-job-reports: 'true'
- name: Setup upx
run: |
UPX_VERSION=3.96
curl --fail --show-error --location --remote-name "https://github.com/upx/upx/releases/download/v$UPX_VERSION/upx-$UPX_VERSION-amd64_linux.tar.xz"
tar -xf upx-$UPX_VERSION-amd64_linux.tar.xz
mv ./upx-$UPX_VERSION-amd64_linux/upx /usr/local/bin/upx
- name: Download compiler jar
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Compiler.jar
path: packages/google-closure-compiler-java/
- name: Download contrib folder
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Contrib folder
path: packages/google-closure-compiler/contrib
- name: Get yarn cache directory path
run: echo "yarn_cache_dir=$(yarn cache dir)" >> $GITHUB_ENV
- name: Cache yarn
uses: actions/cache@v3
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ env.yarn_cache_dir }}
@@ -133,7 +141,7 @@ jobs:
- name: Tests
run: yarn workspaces run test --colors
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Linux image
path: packages/google-closure-compiler-linux/compiler
@@ -144,44 +152,44 @@ jobs:
needs: build-compiler
runs-on: macos-latest
env:
NODE_VERSION: '16.x'
NODE_VERSION: '20.x'
FORCE_COLOR: '1'
steps:
- name: Setup Java
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt-hotspot
java-version: 17
java-version: 21
java-package: jdk
architecture: x64
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- uses: graalvm/setup-graalvm@v1
with:
version: '22.3.2'
java-version: '17'
components: 'native-image'
java-version: 21
distribution: 'graalvm-community'
github-token: ${{ secrets.GITHUB_TOKEN }}
native-image-job-reports: 'true'
# # See https://github.com/google/closure-compiler-npm/issues/265
# - name: Install upx
# run: brew install upx
- name: Download compiler jar
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Compiler.jar
path: packages/google-closure-compiler-java/
- name: Download contrib folder
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Contrib folder
path: packages/google-closure-compiler/contrib
- name: Get yarn cache directory path
run: echo "yarn_cache_dir=$(yarn cache dir)" >> $GITHUB_ENV
- name: Cache yarn
uses: actions/cache@v3
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ env.yarn_cache_dir }}
@@ -199,7 +207,7 @@ jobs:
- name: Tests
run: yarn workspaces run test --colors
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: MacOS image
path: packages/google-closure-compiler-osx/compiler
@@ -210,42 +218,42 @@ jobs:
needs: build-compiler
runs-on: windows-latest
env:
NODE_VERSION: '18.x'
NODE_VERSION: '20.x'
FORCE_COLOR: '1'
steps:
- name: Setup Java
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt-hotspot
java-version: 17
java-version: 21
java-package: jdk
architecture: x64
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- uses: graalvm/setup-graalvm@v1
with:
version: '22.3.2'
java-version: '17'
components: 'native-image'
java-version: 21
distribution: 'graalvm-community'
github-token: ${{ secrets.GITHUB_TOKEN }}
native-image-job-reports: 'true'
- name: Download compiler jar
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Compiler.jar
path: packages/google-closure-compiler-java/
- name: Download contrib folder
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Contrib folder
path: packages/google-closure-compiler/contrib
- name: Get yarn cache directory path
# See https://stackoverflow.com/a/66737579/1211524
run: echo "yarn_cache_dir=$(yarn cache dir)" >> $env:GITHUB_ENV
- name: Cache yarn
uses: actions/cache@v3
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ env.yarn_cache_dir }}
@@ -265,7 +273,7 @@ jobs:
echo "Running Tests"
yarn workspaces run test --colors
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Windows image
path: packages/google-closure-compiler-windows/compiler.exe
@@ -276,7 +284,7 @@ jobs:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
env:
NODE_VERSION: '18.x'
NODE_VERSION: '20.x'
COMPILER_NIGHTLY: ${{ github.event_name == 'schedule' }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_AUTH_TOKEN }}
FORCE_COLOR: '1'
@@ -285,34 +293,34 @@ jobs:
- build-macos
- build-windows
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
registry-url: https://registry.npmjs.org/
- name: Download compiler jar
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Compiler.jar
path: packages/google-closure-compiler-java/
- name: Download Linux image
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Linux image
path: packages/google-closure-compiler-linux/
- name: Download MacOS image
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: MacOS image
path: packages/google-closure-compiler-osx/
- name: Download Windows image
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Windows image
path: packages/google-closure-compiler-windows/
- name: Download contrib folder
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Contrib folder
path: packages/google-closure-compiler/contrib
@@ -324,7 +332,7 @@ jobs:
- name: Get yarn cache directory path
run: echo "yarn_cache_dir=$(yarn cache dir)" >> $GITHUB_ENV
- name: Cache yarn
uses: actions/cache@v3
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ env.yarn_cache_dir }}
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
View file
Original file line number Diff line number Diff line change
@@ -31,11 +31,11 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
@@ -49,7 +49,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -62,6 +62,6 @@ jobs:
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"
21 changes: 13 additions & 8 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
@@ -16,24 +16,29 @@ jobs:
contents: write
env:
FORCE_COLOR: '1'
NODE_VERSION: '18.x'
NODE_VERSION: '20.x'
steps:
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- name: Setup Java
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt-hotspot
java-version: 17
java-version: 21
java-package: jdk
architecture: x64
- name: Setup Bazel
uses: jwlawson/actions-setup-bazel@v1
- name: Setup Bazelisk
uses: bazel-contrib/setup-bazel@0.8.1
with:
bazel-version: '4.2.2'
- uses: actions/checkout@v3
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}
# Share repository cache between workflows.
repository-cache: true
- uses: actions/checkout@v4
with:
submodules: recursive
- name: Set compiler submodule to release branch
Loading