Add TypedAstIntegrationTest to reproduce a Polymer crash

Tests are copied from the existing PolymerIntegrationTest class

PiperOrigin-RevId: 621276538

Author: lauraharker

src/com/google/javascript/jscomp/testing/TestExternsBuilder.java

@@ -958,6 +958,52 @@ public static String getClosureExternsAsSource() {
           "/** @type {string} */",
           "RegExp.$1;");
 
+  private static final String HTML_ELEMENT_EXTERNS =
+      lines(
+          "/** @constructor */",
+          "function Node() {}",
+          "/** @constructor @extends {Node} */",
+          "function Element() {}",
+          "/** @constructor @extends {Element} */",
+          "function HTMLElement() {}");
+
+  private static final String POLYMER_EXTERNS =
+      lines(
+          "",
+          "/**",
+          " * @param {!Object} init",
+          " * @return {!function(new:HTMLElement)}",
+          " */",
+          "function Polymer(init) {}",
+          "",
+          "Polymer.ElementMixin = function(mixin) {}",
+          "",
+          "/** @typedef {!Object} */",
+          "var PolymerElementProperties;",
+          "",
+          "/** @interface */",
+          "function Polymer_ElementMixin() {}",
+          "/** @type {string} */",
+          "Polymer_ElementMixin.prototype._importPath;",
+          "",
+          "/**",
+          "* @interface",
+          "* @extends {Polymer_ElementMixin}",
+          "*/",
+          "function Polymer_LegacyElementMixin(){}",
+          "/** @type {boolean} */",
+          "Polymer_LegacyElementMixin.prototype.isAttached;",
+          "/**",
+          " * @constructor",
+          " * @extends {HTMLElement}",
+          " * @implements {Polymer_LegacyElementMixin}",
+          " */",
+          "var PolymerElement = function() {};", // Polymer 1
+          "",
+          "/** @constructor @extends {HTMLElement} */",
+          "Polymer.Element = function() {};", // Polymer 2
+          "");
+
   private boolean includeBigIntExterns = false;
   private boolean includeIterableExterns = false;
   private boolean includeStringExterns = false;
@@ -976,6 +1022,8 @@ public static String getClosureExternsAsSource() {
   private boolean includeJSCompLibraries = false;
   private boolean includeMathExterns = false;
   private boolean includeRegExpExterns = false;
+  private boolean includeHtmlElementExterns = false;
+  private boolean includePolymerExterns = false;
   private final List<String> extraExterns = new ArrayList<>();
 
   @CanIgnoreReturnValue
@@ -1110,6 +1158,19 @@ public TestExternsBuilder addRegExp() {
     return this;
   }
 
+  @CanIgnoreReturnValue
+  public TestExternsBuilder addHtmlElement() {
+    includeHtmlElementExterns = true;
+    return this;
+  }
+
+  @CanIgnoreReturnValue
+  public TestExternsBuilder addPolymer() {
+    addHtmlElement();
+    includePolymerExterns = true;
+    return this;
+  }
+
   @CanIgnoreReturnValue
   public TestExternsBuilder addExtra(String... lines) {
     Collections.addAll(extraExterns, lines);
@@ -1179,6 +1240,12 @@ public String build() {
     if (includeJSCompLibraries) {
       externSections.add(JSCOMP_LIBRARIES);
     }
+    if (includeHtmlElementExterns) {
+      externSections.add(HTML_ELEMENT_EXTERNS);
+    }
+    if (includePolymerExterns) {
+      externSections.add(POLYMER_EXTERNS);
+    }
     externSections.addAll(extraExterns);
     return LINE_JOINER.join(externSections);
   }

test/com/google/javascript/jscomp/integration/PolymerIntegrationTest.java

@@ -34,6 +34,7 @@
 import com.google.javascript.jscomp.SourceFile;
 import com.google.javascript.jscomp.VariableRenamingPolicy;
 import com.google.javascript.jscomp.parsing.Config.JsDocParsing;
+import com.google.javascript.jscomp.testing.TestExternsBuilder;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -59,23 +60,42 @@ public CompilerOptions createCompilerOptions() {
 
   private void addPolymerExterns() {
     ImmutableList.Builder<SourceFile> externsList = ImmutableList.builder();
-    externsList.addAll(externs);
     externsList.add(
-        SourceFile.fromCode(
-            "polymer_externs.js",
-            lines(
-                "/** @return {function(new: PolymerElement)} */",
-                "var Polymer = function(descriptor) {};",
+        new TestExternsBuilder()
+            .addObject()
+            .addClosureExterns()
+            .addPolymer()
+            .addExtra(
+                "/**",
+                " * @see"
+                    + " https://html.spec.whatwg.org/multipage/custom-elements.html#customelementregistry",
+                " * @constructor",
+                " */",
+                "function CustomElementRegistry() {}",
                 "",
-                "/** @constructor @extends {HTMLElement} */",
-                "var PolymerElement = function() {};", // Polymer 1
+                "/**",
+                " * @param {string} tagName",
+                " * @param {function(new:HTMLElement)} klass",
+                " * @param {{extends: string}=} options",
+                " * @return {undefined}",
+                " */",
+                "CustomElementRegistry.prototype.define = function (tagName, klass, options) {};",
                 "",
-                "/** @constructor @extends {HTMLElement} */",
-                "Polymer.Element = function() {};", // Polymer 2
+                "/**",
+                " * @param {string} tagName",
+                " * @return {function(new:HTMLElement)|undefined}",
+                " */",
+                "CustomElementRegistry.prototype.get = function(tagName) {};",
+                "",
+                "/**",
+                " * @param {string} tagName",
+                " * @return {!Promise<undefined>}",
+                " */",
+                "CustomElementRegistry.prototype.whenDefined = function(tagName) {};",
                 "",
-                "/** @typedef {Object} */",
-                "let PolymerElementProperties;",
-                "")));
+                "/** @type {!CustomElementRegistry} */",
+                "var customElements;")
+            .buildExternsFile("polymer_externs.js"));
     externs = externsList.build();
   }
 
@@ -458,95 +478,14 @@ public void testConstPolymerElementAllowed() {
     testNoWarnings(options, "const Foo = Polymer({ is: 'x-foo' });");
   }
 
-  private void addPolymer2Externs() {
-    ImmutableList.Builder<SourceFile> externsList = ImmutableList.builder();
-    externsList.addAll(externs);
-
-    externsList.add(
-        SourceFile.fromCode(
-            "polymer_externs.js",
-            lines(
-                "",
-                "/**",
-                " * @param {!Object} init",
-                " * @return {!function(new:HTMLElement)}",
-                " */",
-                "function Polymer(init) {}",
-                "",
-                "Polymer.ElementMixin = function(mixin) {}",
-                "",
-                "/** @typedef {!Object} */",
-                "var PolymerElementProperties;",
-                "",
-                "/** @interface */",
-                "function Polymer_ElementMixin() {}",
-                "/** @type {string} */",
-                "Polymer_ElementMixin.prototype._importPath;",
-                "",
-                "/**",
-                "* @interface",
-                "* @extends {Polymer_ElementMixin}",
-                "*/",
-                "function Polymer_LegacyElementMixin(){}",
-                "/** @type {boolean} */",
-                "Polymer_LegacyElementMixin.prototype.isAttached;",
-                "/**",
-                " * @constructor",
-                " * @extends {HTMLElement}",
-                " * @implements {Polymer_LegacyElementMixin}",
-                " */",
-                "var PolymerElement = function() {};",
-                "")));
-
-    externsList.add(
-        SourceFile.fromCode(
-            "html5.js",
-            lines(
-                "/** @constructor */",
-                "function Element() {}",
-                "",
-                "/**",
-                " * @see"
-                    + " https://html.spec.whatwg.org/multipage/custom-elements.html#customelementregistry",
-                " * @constructor",
-                " */",
-                "function CustomElementRegistry() {}",
-                "",
-                "/**",
-                " * @param {string} tagName",
-                " * @param {function(new:HTMLElement)} klass",
-                " * @param {{extends: string}=} options",
-                " * @return {undefined}",
-                " */",
-                "CustomElementRegistry.prototype.define = function (tagName, klass, options) {};",
-                "",
-                "/**",
-                " * @param {string} tagName",
-                " * @return {function(new:HTMLElement)|undefined}",
-                " */",
-                "CustomElementRegistry.prototype.get = function(tagName) {};",
-                "",
-                "/**",
-                " * @param {string} tagName",
-                " * @return {!Promise<undefined>}",
-                " */",
-                "CustomElementRegistry.prototype.whenDefined = function(tagName) {};",
-                "",
-                "/** @type {!CustomElementRegistry} */",
-                "var customElements;",
-                "")));
-
-    externs = externsList.build();
-  }
-
   // Regression test for b/77650996
   @Test
   public void testPolymer2b() {
     CompilerOptions options = createCompilerOptions();
     options.setPolymerVersion(2);
     options.setWarningLevel(DiagnosticGroups.CHECK_TYPES, CheckLevel.ERROR);
     options.setLanguageOut(LanguageMode.ECMASCRIPT5);
-    addPolymer2Externs();
+    addPolymerExterns();
 
     test(
         options,
@@ -575,13 +514,6 @@ public void testPolymer2b() {
               "   * @extends {HTMLElement}",
               "   */",
               "  const Element = Polymer.ElementMixin(HTMLElement);",
-              "",
-              "  /**",
-              "   * @constructor",
-              "   * @implements {Polymer_ElementMixin}",
-              "   * @extends {HTMLElement}",
-              "   */",
-              "  Polymer.Element = Element;",
               "})();",
               ""),
         },
@@ -594,7 +526,7 @@ public void testPolymer1b() {
     options.setPolymerVersion(2);
     options.setWarningLevel(DiagnosticGroups.CHECK_TYPES, CheckLevel.ERROR);
     options.setLanguageOut(LanguageMode.ECMASCRIPT5);
-    addPolymer2Externs();
+    addPolymerExterns();
 
     test(
         options,
@@ -611,13 +543,6 @@ public void testPolymer1b() {
               "   * @extends {HTMLElement}",
               "   */",
               "  const Element = Polymer.ElementMixin(HTMLElement);",
-              "",
-              "  /**",
-              "   * @constructor",
-              "   * @implements {Polymer_ElementMixin}",
-              "   * @extends {HTMLElement}",
-              "   */",
-              "  Polymer.Element = Element;",
               "})();",
               ""),
         },
@@ -820,7 +745,7 @@ public void testPolymerPropertyDeclarationsWithConstructor() {
     // is injected into the externs. We need to make sure the types of the properties on this
     // interface aligns with the types we declared in the constructor, or else we'll get an error.
     options.setPolymerExportPolicy(PolymerExportPolicy.EXPORT_ALL);
-    addPolymer2Externs();
+    addPolymerExterns();
 
     Compiler compiler =
         compile(