Fix TypeInference crash on goog.requireDynamic for a missing source

PiperOrigin-RevId: 617957576

Author: lauraharker

src/com/google/javascript/jscomp/TypeInference.java

@@ -1976,9 +1976,9 @@ private FlowScope setCallNodeTypeAfterChildrenTraversed(Node n, FlowScope scopeA
   private @Nullable JSType getGoogModuleDependencyCallResultType(Node callNode) {
     String moduleId = callNode.getSecondChild().getString();
     Module module = compiler.getModuleMap().getClosureModule(moduleId);
-    // Only declared module ids.
+    // Fall back to the `?` type if the module is unknown to the compiler
     if (module == null) {
-      return null;
+      return unknownType;
     }
 
     ScopedName name = moduleImportResolver.getClosureNamespaceTypeFromCall(callNode);
@@ -1987,7 +1987,7 @@ private FlowScope setCallNodeTypeAfterChildrenTraversed(Node n, FlowScope scopeA
       TypedVar otherVar =
           otherModuleScope != null ? otherModuleScope.getSlot(name.getName()) : null;
       if (otherVar != null) {
-        return otherVar.getType();
+        return otherVar.getType() != null ? otherVar.getType() : unknownType;
       }
 
       if (otherModuleScope != null && module.metadata().moduleType() == ModuleType.GOOG_PROVIDE) {

test/com/google/javascript/jscomp/TypeCheckTest.java

@@ -23511,6 +23511,31 @@ public void testSymbolIteratorMethod() {
         .run();
   }
 
+  @Test
+  public void testGoogRequireDynamic_missingSources() {
+    // regression test for case that used to throw an exception
+    newTest()
+        .addSource(
+            "class Test {",
+            " /**",
+            "  * @return {!Object}",
+            "  *",
+            "  * @suppress {missingSourcesWarnings} reference to dynamically loaded",
+            "  * namespace.",
+            "  * @suppress {checkTypes}",
+            "  */",
+            "testGoogRequireDynamicStubbedAndWithLoadedModule() {",
+            "   goog.setImportHandlerInternalDoNotCallOrElse(() => Promise.resolve(null));",
+            "   goog.setUncompiledChunkIdHandlerInternalDoNotCallOrElse(s => s);",
+            "",
+            "   goog.loadModule('goog.module(\"a.loaded.module\"); exports.foo = 12;');",
+            "",
+            "   return goog.requireDynamic('a.loaded.module')",
+            "       .then(({foo}) => assertEquals(foo, 12));",
+            " } }")
+        .run();
+  }
+
   @Test
   public void testClassMultipleExtends_fromClosureJs() {
     // Tests a workaround for b/325489639