Quote string key properties in Polymer behaviors

Polymer behaviors with string key property on `listeners` and `hostAttributes` need to be marked as quoted. Otherwise we run the risk of renaming them.

PiperOrigin-RevId: 715560110

Author: rahul-kamat

src/com/google/javascript/jscomp/PolymerPass.java

@@ -75,8 +75,8 @@ public void process(Node externs, Node root) {
 
     Node externsAndJsRoot = root.getParent();
     NodeTraversal.traverse(compiler, externsAndJsRoot, this);
-    PolymerPassSuppressBehaviorsAndProtectKeys suppressBehaviorsCallback =
-        new PolymerPassSuppressBehaviorsAndProtectKeys(compiler);
+    PolymerPassSuppressBehaviors suppressBehaviorsCallback =
+        new PolymerPassSuppressBehaviors(compiler);
     NodeTraversal.traverse(compiler, externsAndJsRoot, suppressBehaviorsCallback);
   }
 

src/com/google/javascript/jscomp/PolymerPassSuppressBehaviorsAndProtectKeys.java src/com/google/javascript/jscomp/PolymerPassSuppressBehaviors.java

@@ -25,15 +25,12 @@
 /**
  * For every Polymer Behavior, strip property type annotations and add suppress checktypes on
  * functions.
- *
- * <p>Also find listener and hostAttribute keys in the behavior, and mark them as quoted. This
- * protects the keys from being renamed.
  */
-final class PolymerPassSuppressBehaviorsAndProtectKeys extends ExternsSkippingCallback {
+final class PolymerPassSuppressBehaviors extends ExternsSkippingCallback {
 
   private final AbstractCompiler compiler;
 
-  PolymerPassSuppressBehaviorsAndProtectKeys(AbstractCompiler compiler) {
+  PolymerPassSuppressBehaviors(AbstractCompiler compiler) {
     this.compiler = compiler;
   }
 
@@ -45,10 +42,6 @@ public void visit(NodeTraversal t, Node n, Node parent) {
         return;
       }
 
-      // Find listener and hostAttribute keys in the behavior, and mark them as quoted.
-      // This ensures that the keys are not renamed.
-      traverseBehaviorandfindListenerAndHostAttributeAndMarkKeysAsQuoted(n);
-
       // Add @nocollapse.
       JSDocInfo.Builder newDocs = JSDocInfo.Builder.maybeCopyFrom(n.getJSDocInfo());
       newDocs.recordNoCollapse();
@@ -62,17 +55,6 @@ public void visit(NodeTraversal t, Node n, Node parent) {
     }
   }
 
-  /** Traverse the behavior, find listener and hostAttribute keys, and mark them as quoted. */
-  private void traverseBehaviorandfindListenerAndHostAttributeAndMarkKeysAsQuoted(Node n) {
-    if (n.isObjectLit()) {
-      PolymerPassStaticUtils.quoteListenerAndHostAttributeKeys(n, compiler);
-    }
-
-    for (Node child = n.getFirstChild(); child != null; child = child.getNext()) {
-      traverseBehaviorandfindListenerAndHostAttributeAndMarkKeysAsQuoted(child);
-    }
-  }
-
   /** Strip property type annotations and add suppressions on functions. */
   private void suppressBehavior(Node behaviorValue, Node reportNode) {
     if (behaviorValue == null) {

test/com/google/javascript/jscomp/PolymerPassSuppressBehaviorsAndProtectKeysTest.java test/com/google/javascript/jscomp/PolymerPassSuppressBehaviorsTest.java

@@ -21,9 +21,9 @@
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
-/** Unit tests for {@link PolymerPassSuppressBehaviorsAndProtectKeys} */
+/** Unit tests for {@link PolymerPassSuppressBehaviors} */
 @RunWith(JUnit4.class)
-public class PolymerPassSuppressBehaviorsAndProtectKeysTest extends CompilerTestCase {
+public class PolymerPassSuppressBehaviorsTest extends CompilerTestCase {
 
   private static final String EXTERNS =
       lines(
@@ -58,7 +58,7 @@ public class PolymerPassSuppressBehaviorsAndProtectKeysTest extends CompilerTest
           "var Polymer = function(a) {};",
           "var alert = function(msg) {};");
 
-  public PolymerPassSuppressBehaviorsAndProtectKeysTest() {
+  public PolymerPassSuppressBehaviorsTest() {
     super(EXTERNS);
   }
 
@@ -67,8 +67,8 @@ protected CompilerPass getProcessor(final Compiler compiler) {
     return new CompilerPass() {
       @Override
       public void process(Node externs, Node root) {
-        PolymerPassSuppressBehaviorsAndProtectKeys suppressBehaviorsCallback =
-            new PolymerPassSuppressBehaviorsAndProtectKeys(compiler);
+        PolymerPassSuppressBehaviors suppressBehaviorsCallback =
+            new PolymerPassSuppressBehaviors(compiler);
         NodeTraversal.traverse(compiler, root, suppressBehaviorsCallback);
       }
     };

test/com/google/javascript/jscomp/PolymerPassTest.java

@@ -1052,35 +1052,6 @@ public void testListenersAndHostAttributeKeysQuoted() {
             "X.prototype.handleClick;"));
   }
 
-  @Test
-  public void testPolymerBehaviorListenersAndHostAttributeKeysQuoted() {
-    // Polymer behaviors with string key property on listeners and hostAttributes need to be marked
-    // as quoted.
-    // This is the bugfix for b/388337323.
-    test(
-        srcs(
-            lines(
-                "/** @polymerBehavior */",
-                "exports.CheckedOnTapBehavior = {",
-                "  listeners: {tap: 'onTap'},",
-                "  hostAttributes: {foo: 1},",
-                "  onTap() {",
-                "    this.checked = true;",
-                "  },",
-                "};")),
-        expected(
-            lines(
-                "/** @polymerBehavior @nocollapse */",
-                "exports.CheckedOnTapBehavior = {",
-                "  listeners: {'tap': 'onTap'},",
-                "  hostAttributes: {'foo': 1},",
-                "  /** @suppress {checkTypes|globalThis|visibility} */",
-                "  onTap() {",
-                "    this.checked = true;",
-                "  },",
-                "};")));
-  }
-
   @Test
   public void testNativeElementExtension() {
     String js = lines("Polymer({", "  is: 'x-input',", "  extends: 'input',", "});");