Rename removeDeadCode to removeUnreachableCode.

"dead code" is extremely ambiguous where as "unreachable" is more often used when talking about CFG code removals.

PiperOrigin-RevId: 609196804

Author: concavelenz

src/com/google/javascript/jscomp/CompilationLevel.java

@@ -130,7 +130,7 @@ private static void applySafeCompilationOptions(CompilerOptions options) {
     options.setCollapseVariableDeclarations(true);
     options.convertToDottedProperties = true;
     options.labelRenaming = true;
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setOptimizeArgumentsArray(true);
     options.setRemoveUnusedVariables(Reach.LOCAL_ONLY);
     options.collapseObjectLiterals = true;
@@ -161,7 +161,7 @@ private static void applyFullCompilationOptions(CompilerOptions options) {
     options.setCollapseVariableDeclarations(true);
     options.setConvertToDottedProperties(true);
     options.setLabelRenaming(true);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setOptimizeArgumentsArray(true);
     options.setCollapseObjectLiterals(true);
     options.setProtectHiddenSideEffects(true);

src/com/google/javascript/jscomp/CompilerOptions.java

@@ -453,7 +453,7 @@ public void setNumParallelThreads(int parallelism) {
   public boolean smartNameRemoval;
 
   /** Removes code that will never execute */
-  public boolean removeDeadCode;
+  public boolean removeUnreachableCode;
 
   public enum ExtractPrototypeMemberDeclarationsMode {
     OFF,
@@ -1306,7 +1306,7 @@ public CompilerOptions() {
     inlineVariables = false;
     inlineLocalVariables = false;
     smartNameRemoval = false;
-    removeDeadCode = false;
+    removeUnreachableCode = false;
     extractPrototypeMemberDeclarations = ExtractPrototypeMemberDeclarationsMode.OFF;
     removeUnusedPrototypeProperties = false;
     removeUnusedClassProperties = false;
@@ -2092,8 +2092,16 @@ public void setSmartNameRemoval(boolean smartNameRemoval) {
     }
   }
 
-  public void setRemoveDeadCode(boolean removeDeadCode) {
-    this.removeDeadCode = removeDeadCode;
+  /**
+   * @deprecated Use {@link #setRemoveUnreachableCode} instead.
+   */
+  @Deprecated
+  public void setRemoveDeadCode(boolean removeUnreachableCode) {
+    setRemoveUnreachableCode(removeUnreachableCode);
+  }
+
+  public void setRemoveUnreachableCode(boolean removeUnreachableCode) {
+    this.removeUnreachableCode = removeUnreachableCode;
   }
 
   public void setExtractPrototypeMemberDeclarations(boolean enabled) {
@@ -2889,8 +2897,8 @@ public String toString() {
         .add("quoteKeywordProperties", quoteKeywordProperties)
         .add("removeAbstractMethods", removeAbstractMethods)
         .add("removeClosureAsserts", removeClosureAsserts)
-        .add("removeDeadCode", removeDeadCode)
         .add("removeJ2clAsserts", removeJ2clAsserts)
+        .add("removeUnreachableCode", removeUnreachableCode)
         .add("removeUnusedClassProperties", removeUnusedClassProperties)
         .add("removeUnusedConstructorProperties", removeUnusedConstructorProperties)
         .add("removeUnusedLocalVars", removeUnusedLocalVars)

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -993,7 +993,7 @@ private PassListBuilder getEarlyOptimizationLoopPasses() {
       earlyLoopPasses.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeDeadCode) {
+    if (options.removeUnreachableCode) {
       earlyLoopPasses.maybeAdd(removeUnreachableCode);
     }
 
@@ -1068,7 +1068,7 @@ private PassListBuilder getPostL10nOptimizations() {
       loopPasses.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeDeadCode) {
+    if (options.removeUnreachableCode) {
       loopPasses.maybeAdd(removeUnreachableCode);
     }
     loopPasses.assertAllLoopablePasses();
@@ -1137,7 +1137,7 @@ private PassListBuilder getMainOptimizationLoop() {
       passes.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeDeadCode) {
+    if (options.removeUnreachableCode) {
       passes.maybeAdd(removeUnreachableCode);
     }
 

src/com/google/javascript/jscomp/debugger/common/CompilationParam.java

@@ -693,12 +693,12 @@ public String getJavaInfo() {
   REMOVE_DEAD_CODE(ParamGroup.OPTIMIZATION) {
     @Override
     public void apply(CompilerOptions options, boolean value) {
-      options.setRemoveDeadCode(value);
+      options.setRemoveUnreachableCode(value);
     }
 
     @Override
     public boolean isApplied(CompilerOptions options) {
-      return options.removeDeadCode;
+      return options.removeUnreachableCode;
     }
   },
 

test/com/google/javascript/jscomp/integration/IntegrationTest.java

@@ -401,7 +401,7 @@ public void testIssue90() {
     CompilerOptions options = createCompilerOptions();
     options.setFoldConstants(true);
     options.setInlineVariables(true);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     test(options, "var x; x && alert(1);", "");
   }
 
@@ -1476,7 +1476,7 @@ public void testDisambiguateProperties2() {
     options.setClosurePass(true);
     options.setCheckTypes(true);
     options.setDisambiguateProperties(true);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setRemoveAbstractMethods(true);
     test(
         options,
@@ -1504,7 +1504,7 @@ public void testDisambiguatePropertiesWithPropertyInvalidationError() {
     options.setCheckTypes(true);
     options.setDisambiguateProperties(true);
     options.setPropertiesThatMustDisambiguate(ImmutableSet.of("a"));
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setRemoveAbstractMethods(true);
     test(
         options,
@@ -1531,7 +1531,7 @@ public void testDisambiguatePropertiesWithPropertyInvalidationError() {
   public void testMarkPureCalls() {
     String testCode = "function foo() {} foo();";
     CompilerOptions options = createCompilerOptions();
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
 
     testSame(options, testCode);
 
@@ -1748,7 +1748,7 @@ public void testRemoveUnreachableCode() {
     String code = "function f() { return; f(); }";
     testSame(options, code);
 
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     test(options, code, "function f() {}");
   }
 
@@ -1784,7 +1784,7 @@ public void testSmartNamePassBug11163486() {
 
     options.setCheckTypes(true);
     options.setDisambiguateProperties(true);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setRemoveUnusedVariables(Reach.ALL);
     options.setRemoveUnusedPrototypeProperties(true);
     options.setSmartNameRemoval(true);
@@ -1832,7 +1832,7 @@ public void testDeadCodeHasNoDisambiguationSideEffects() {
 
     options.setCheckTypes(true);
     options.setDisambiguateProperties(true);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setRemoveUnusedVariables(Reach.ALL);
     options.setRemoveUnusedPrototypeProperties(true);
     options.setSmartNameRemoval(true);
@@ -4804,7 +4804,7 @@ public void testDeclareLegacyNamespaceSubModuleCrash() {
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
     options.setLanguageOut(LanguageMode.ECMASCRIPT_2016);
 
-    options.setRemoveDeadCode(false);
+    options.setRemoveUnreachableCode(false);
     options.setRemoveUnusedVariables(Reach.NONE);
     options.setRemoveUnusedClassProperties(false);
 

test/com/google/javascript/jscomp/integration/PolymerIntegrationTest.java

@@ -780,7 +780,7 @@ public void testPolymerExportPolicyExportAllLegacyElement() {
     options.setRenamingPolicy(VariableRenamingPolicy.ALL, PropertyRenamingPolicy.ALL_UNQUOTED);
     options.setRemoveUnusedPrototypeProperties(true);
     options.setRemoveUnusedVariables(Reach.ALL);
-    options.setRemoveDeadCode(true);
+    options.setRemoveUnreachableCode(true);
     options.setPolymerExportPolicy(PolymerExportPolicy.EXPORT_ALL);
     options.setGenerateExports(true);
     options.setExportLocalPropertyDefinitions(true);