Support @noinline on parameters and have OptimizeParameters back off when observing it.

This is necessary to support code relying on constructing objects via `.constructor` properties.  Otherwise the compiler can violate application expectations by deleting or inlining parameters.

PiperOrigin-RevId: 703246338

Author: lukesandberg

src/com/google/javascript/jscomp/OptimizeParameters.java

@@ -670,7 +670,9 @@ private boolean allDefinitionsAreCandidateFunctions(Node n) {
             return !NodeUtil.doesFunctionReferenceOwnArgumentsObject(functionNode)
                 // In `function f(a, b = a) { ... }` it's very difficult to determine if `a` is
                 // movable.
-                && !mayReferenceParamBeforeBody(functionNode);
+                && !mayReferenceParamBeforeBody(functionNode)
+                // `function f(/** @noinline */ a) {...}` means back off.
+                && !mayHaveNoInlineParameters(functionNode);
           }
         }
       case FUNCTION:
@@ -679,7 +681,9 @@ private boolean allDefinitionsAreCandidateFunctions(Node n) {
             // "arguments" can refer to all parameters or their count.
             && !NodeUtil.doesFunctionReferenceOwnArgumentsObject(n)
             // In `function f(a, b = a) { ... }` it's very difficult to determine if `a` is movable.
-            && !mayReferenceParamBeforeBody(n);
+            && !mayReferenceParamBeforeBody(n)
+            // `function f(/** @noinline */ a) {...}` means back off.
+            && !mayHaveNoInlineParameters(n);
       case CAST:
       case COMMA:
         return allDefinitionsAreCandidateFunctions(n.getLastChild());
@@ -696,6 +700,26 @@ private boolean allDefinitionsAreCandidateFunctions(Node n) {
     }
   }
 
+  /**
+   * Returns true if the function has any parameters tagged with @noinline.
+   *
+   * <p>In this case we just back off on all parameter optimizations. We could be more clever and
+   * only back off on the ones tagged @noinline, but it's not worth the complexity.
+   */
+  private static boolean mayHaveNoInlineParameters(Node function) {
+    Node paramList = function.getSecondChild();
+    if (!paramList.hasChildren()) {
+      return false; // Fast path; there can't possibly be @noinline params.
+    }
+    for (Node param = paramList.getFirstChild(); param != null; param = param.getNext()) {
+      var jsDocInfo = param.getJSDocInfo();
+      if (jsDocInfo != null && jsDocInfo.isNoInline()) {
+        return true;
+      }
+    }
+    return false;
+  }
+
   /**
    * Does the function use one of its parameters in code before the body?
    *

test/com/google/javascript/jscomp/OptimizeParametersTest.java

@@ -409,6 +409,7 @@ public void testSimpleRemoval1() {
     test(
         "const foo = (p1)=>{       }; foo(); foo()", //
         "const foo = (  )=>{var p1;}; foo(); foo()");
+    testSame("const foo = (/** @noinline */ p1)=>{}; foo(); foo()");
 
     // constant parameter
     test(
@@ -420,6 +421,7 @@ public void testSimpleRemoval1() {
     test(
         "const foo = (p1)=>{           }; foo(1); foo(1)",
         "const foo = (  )=>{var p1 = 1;}; foo( ); foo( )");
+    testSame("const foo = (/** @noinline */ p1)=>{}; foo(1); foo(1)");
   }
 
   @Test
@@ -439,6 +441,7 @@ public void testSimpleRemoval2() {
     test(
         "function f(p1) {           } new f(1,x()); new f(1,y())",
         "function f(  ) {var p1 = 1;} new f(  x()); new f(  y())");
+    testSame("function f(/** @noinline */ p1) {} new f(); new f()");
   }
 
   @Test
@@ -466,15 +469,22 @@ public void testSimpleRemoval4() {
     test(
         "function f(p1) {       } f.prop = 1; new f(); new f()",
         "function f(  ) {var p1;} f.prop = 1; new f(); new f()");
+    testSame("function f(/** @noinline */ p1) {} f.prop = 1; new f(); new f()");
+
     test(
         "function f(p1) {           } f.prop = 1; new f(1); new f(1)",
         "function f(  ) {var p1 = 1;} f.prop = 1; new f( ); new f( )");
+    testSame("function f(/** @noinline */ p1) {} f.prop = 1; new f(1); new f(1)");
+
     test(
         "function f(p1) {       } f['prop'] = 1; new f(); new f()",
         "function f(  ) {var p1;} f['prop'] = 1; new f(); new f()");
+    testSame("function f(/** @noinline */ p1) {} f['prop'] = 1; new f(); new f()");
+
     test(
         "function f(p1) {           } f['prop'] = 1; new f(1); new f(1)",
         "function f(  ) {var p1 = 1;} f['prop'] = 1; new f( ); new f( )");
+    testSame("function f(/** @noinline */ p1) {} f['prop'] = 1; new f(1); new f(1)");
   }
 
   @Test