Use LinkedHash(Map|Set) to guarantee deterministic iteration order

parsing

PiperOrigin-RevId: 614828574

Author: brad4d

src/com/google/javascript/jscomp/parsing/IRFactory.java

@@ -136,7 +136,6 @@
 import java.math.BigInteger;
 import java.util.ArrayDeque;
 import java.util.Deque;
-import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Set;
@@ -193,6 +192,7 @@ class IRFactory {
 
   private final StaticSourceFile sourceFile;
   private final @Nullable String sourceName;
+
   /** Source file reference that also contains the file content. */
   private final SourceFile fileWithContent;
 
@@ -227,7 +227,7 @@ class IRFactory {
   /** If non-null, use this set of keywords instead of TokenStream.isKeyword(). */
   private final @Nullable ImmutableSet<String> reservedKeywords;
 
-  private final Set<Comment> parsedComments = new HashSet<>();
+  private final Set<Comment> parsedComments = new LinkedHashSet<>();
 
   private final LinkedHashSet<String> licenseBuilder = new LinkedHashSet<>();
   private @Nullable JSDocInfo firstFileoverview = null;
@@ -288,8 +288,7 @@ private static final class CommentTracker {
       this.advance();
     }
 
-    @Nullable
-    Comment current() {
+    @Nullable Comment current() {
       return (this.index >= this.source.size()) ? null : this.source.get(this.index);
     }
 

src/com/google/javascript/jscomp/parsing/JsDocInfoParser.java

@@ -38,7 +38,7 @@
 import com.google.javascript.rhino.TokenStream;
 import com.google.javascript.rhino.TokenUtil;
 import java.util.ArrayList;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Set;
 import org.jspecify.nullness.Nullable;
@@ -1362,7 +1362,7 @@ private JsDocToken parseSuppressTag(JsDocToken token) {
       addParserWarning(Msg.JSDOC_SUPPRESS);
       return token;
     } else {
-      Set<String> suppressions = new HashSet<>();
+      Set<String> suppressions = new LinkedHashSet<>();
       while (true) {
         if (match(JsDocToken.STRING)) {
           String name = stream.getString();
@@ -1465,7 +1465,7 @@ private JsDocToken parseClosurePrimitiveTag(JsDocToken token) {
    */
   private JsDocToken parseModifiesTag(JsDocToken token) {
     if (token == JsDocToken.LEFT_CURLY) {
-      Set<String> modifies = new HashSet<>();
+      Set<String> modifies = new LinkedHashSet<>();
       while (true) {
         if (match(JsDocToken.STRING)) {
           String name = stream.getString();
@@ -2577,7 +2577,7 @@ private Node parseRecordType(JsDocToken token) {
   private @Nullable Node parseFieldTypeList(JsDocToken token) {
     Node fieldTypeList = newNode(Token.LB);
 
-    Set<String> names = new HashSet<>();
+    Set<String> names = new LinkedHashSet<>();
 
     do {
       Node fieldType = parseFieldType(token);

src/com/google/javascript/jscomp/parsing/ParserRunner.java

@@ -35,7 +35,7 @@
 import com.google.javascript.rhino.ErrorReporter;
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.StaticSourceFile;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Set;
 import org.jspecify.nullness.Nullable;
@@ -75,7 +75,7 @@ public static Config createConfig(
     if (extraAnnotationNames == null) {
       effectiveAnnotationNames = annotationNames;
     } else {
-      effectiveAnnotationNames = new HashSet<>(annotationNames);
+      effectiveAnnotationNames = new LinkedHashSet<>(annotationNames);
       effectiveAnnotationNames.addAll(extraAnnotationNames);
     }
     return Config.builder()
@@ -188,9 +188,7 @@ private static class Es6ErrorReporter
     private boolean errorSeen = false;
     private final boolean reportAllErrors;
 
-    Es6ErrorReporter(
-        ErrorReporter reporter,
-        boolean reportAllErrors) {
+    Es6ErrorReporter(ErrorReporter reporter, boolean reportAllErrors) {
       this.reporter = reporter;
       this.reportAllErrors = reportAllErrors;
     }
@@ -201,23 +199,17 @@ protected void reportError(SourcePosition location, String message) {
       // sometimes it is useful to keep going.
       if (reportAllErrors || !errorSeen) {
         errorSeen = true;
-        this.reporter.error(
-            message, location.source.name,
-            location.line + 1, location.column);
+        this.reporter.error(message, location.source.name, location.line + 1, location.column);
       }
     }
 
     @Override
     protected void reportWarning(SourcePosition location, String message) {
-      this.reporter.warning(
-          message, location.source.name,
-          location.line + 1, location.column);
+      this.reporter.warning(message, location.source.name, location.line + 1, location.column);
     }
   }
 
-  /**
-   * Holds results of parsing.
-   */
+  /** Holds results of parsing. */
   public static class ParseResult {
     public final Node ast;
     public final List<Comment> comments;