Added public field this support for computed field to ClosureCheckModule for false positives.

This fixes `JSC_GOOG_MODULE_REFERENCES_THIS` error thrown when a public field was assigned using the `this[property]`.

ClosureCheckModule now checks if the assignment is allowed given that the `this` is not inside a goog.module by updating the hoist scope.

PiperOrigin-RevId: 620887878

Author: Closure Team

src/com/google/javascript/jscomp/NodeTraversal.java

@@ -1085,6 +1085,9 @@ private void handleClassMembers(Node n, Node parent) {
           break;
         case COMPUTED_FIELD_DEF:
           currentNode = n;
+
+          Node previousHoistScopeRoot = currentHoistScopeRoot;
+          currentHoistScopeRoot = n;
           pushScope(child);
 
           if (callback.shouldTraverse(this, child, n)) {
@@ -1096,6 +1099,7 @@ private void handleClassMembers(Node n, Node parent) {
           }
 
           popScope();
+          currentHoistScopeRoot = previousHoistScopeRoot;
           break;
         case MEMBER_FIELD_DEF:
           handleMemberFieldDef(n, child);

test/com/google/javascript/jscomp/ClosureCheckModuleTest.java

@@ -77,6 +77,26 @@ public void testGoogModuleThisInSubclass() {
             "class Bar extends Foo {", //
             "   z = this.x;",
             "}"));
+
+    testSame(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  [x] = 5;",
+            "}",
+            "class Bar extends Foo {", //
+            "   z = this[x];",
+            "}"));
+
+    testSame(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  [x] = 5;",
+            "}",
+            "class Bar extends Foo {", //
+            "   [z] = this[x];",
+            "}"));
   }
 
   @Test
@@ -89,6 +109,23 @@ public void testGoogModuleThisOnFields() {
             "  x = 5;",
             "  y = this.x",
             "}"));
+
+    testSame(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  [x] = 5;",
+            "  [y] = this[x]",
+            "}"));
+
+    testError(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  [x] = 5;",
+            "  [this.x] = 6",
+            "}"),
+        GOOG_MODULE_REFERENCES_THIS);
   }
 
   @Test
@@ -101,6 +138,14 @@ public void testStaticGoogModuleThisOnStaticFields() {
             "  static x = 5;",
             "  static y = this.x",
             "}"));
+
+    testSame(
+        lines(
+            "goog.module('math')", //
+            "class Foo {",
+            "  static [x] = 5;",
+            "  static [y] = this[x]",
+            "}"));
   }
 
   @Test