Skip to content

Commit 519a959

Browse files
committed
Fix missing overrides that were omitted due to the now-deleted J2CL build
For CompilerTestCase, just removes the missing override suppression without adding @OverRide, since overriding getName() doesn't actually work with @OverRide. PiperOrigin-RevId: 707162967
1 parent 4c8c6ed commit 519a959

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/com/google/javascript/jscomp/DefaultNameGenerator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ private static final class CharPriority implements Comparable<CharPriority>, Ser
5353
this.occurrence = 0;
5454
}
5555

56-
// @Override removed for GWT compatibility
56+
@Override
5757
public CharPriority clone() {
5858
CharPriority result = new CharPriority(name, order);
5959
result.occurrence = occurrence;

src/com/google/javascript/rhino/JSDocInfo.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ private Builder toBuilder(@Nullable TypeTransform transform) {
651651
return builder;
652652
}
653653

654-
@SuppressWarnings("MissingOverride") // Adding @Override breaks the GWT compilation.
654+
@Override
655655
public JSDocInfo clone() {
656656
return clone(false);
657657
}

test/com/google/javascript/jscomp/CompilerTestCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,6 @@ protected CompilerTestCase() {
664664
this("");
665665
}
666666

667-
@SuppressWarnings("MissingOverride")
668667
public String getName() {
669668
return this.getClass().getSimpleName();
670669
}

0 commit comments

Comments
 (0)