Run mergeSyntheticScript even in checksOnly mode

PiperOrigin-RevId: 622878192

Author: lauraharker

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -465,14 +465,11 @@ protected PassListBuilder getChecks() {
 
     checks.maybeAdd(createEmptyPass(PassNames.AFTER_STANDARD_CHECKS));
 
-    if (options.checksOnly) {
-      checks.maybeAdd(removeSyntheticScript);
-    } else if (!options.checksOnly) {
-      checks.maybeAdd(mergeSyntheticScript);
-      // At this point all checks have been done.
-      if (options.exportTestFunctions) {
-        checks.maybeAdd(exportTestFunctions);
-      }
+    checks.maybeAdd(mergeSyntheticScript);
+
+    // At this point all checks have been done.
+    if (!options.checksOnly && options.exportTestFunctions) {
+      checks.maybeAdd(exportTestFunctions);
     }
 
     // Create extern exports after the normalize because externExports depends on unique names.

test/com/google/javascript/jscomp/integration/TypedAstIntegrationTest.java

@@ -761,15 +761,13 @@ public void testPolymer_propertiesOnLegacyElementNotRenamed_inGoogModule() throw
                 "  },",
                 "});")));
 
-    // TODO(b/218711238): investigate this crash
-    assertThrows(NullPointerException.class, () -> compileTypedAstShards(options));
-    // Compiler compiler = compileTypedAstShards(options);
-    // String source = compiler.toSource();
-
-    // // If we see these identifiers anywhere in the output source, we know that we successfully
-    // // protected them against removal and renaming.
-    // assertThat(source).contains("longUnusedProperty");
-    // assertThat(source).contains("longUnusedMethod");
+    Compiler compiler = compileTypedAstShards(options);
+    String source = compiler.toSource();
+
+    // If we see these identifiers anywhere in the output source, we know that we successfully
+    // protected them against removal and renaming.
+    assertThat(source).contains("longUnusedProperty");
+    assertThat(source).contains("longUnusedMethod");
   }
 
   // use over 'compileTypedAstShards' if you want to validate reported errors or warnings in your