Skip to content

Commit 67458e6

Browse files
concavelenzcopybara-github
authored andcommitted
Remove unneeded reference to GlobalNamespace
PiperOrigin-RevId: 622324556
1 parent 12188c4 commit 67458e6

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

src/com/google/javascript/jscomp/PolymerClassDefinition.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ private static Node createDummyGoogModuleExportsTarget(AbstractCompiler compiler
285285
* opposed to the Polymer 1 extraction, this operation is non-destructive.
286286
*/
287287
static @Nullable PolymerClassDefinition extractFromClassNode(
288-
Node classNode, AbstractCompiler compiler, GlobalNamespace globalNames) {
288+
Node classNode, AbstractCompiler compiler) {
289289
checkState(classNode != null && classNode.isClass());
290290

291291
// The supported case is for the config getter to return an object literal descriptor.

src/com/google/javascript/jscomp/PolymerPass.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import static com.google.common.base.MoreObjects.toStringHelper;
1919
import static com.google.common.base.Preconditions.checkArgument;
20-
import static com.google.common.base.Preconditions.checkNotNull;
2120
import static com.google.javascript.jscomp.PolymerPassErrors.POLYMER_INVALID_EXTENDS;
2221
import static com.google.javascript.jscomp.PolymerPassErrors.POLYMER_MISSING_EXTERNS;
2322

@@ -109,8 +108,6 @@ public void process(Node externs, Node root) {
109108

110109
@Override
111110
public void visit(NodeTraversal traversal, Node node, Node parent) {
112-
checkNotNull(globalNames, "Cannot call visit() before process()");
113-
114111
if (PolymerPassStaticUtils.isPolymerCall(node)) {
115112
if (polymerElementExterns != null) {
116113
rewritePolymer1ClassDefinition(node, parent, traversal);
@@ -171,8 +168,7 @@ private void rewritePolymer1ClassDefinition(Node node, Node parent, NodeTraversa
171168

172169
/** Polymer 2.x Class Nodes */
173170
private void rewritePolymer2ClassDefinition(Node node, NodeTraversal traversal) {
174-
PolymerClassDefinition def =
175-
PolymerClassDefinition.extractFromClassNode(node, compiler, globalNames);
171+
PolymerClassDefinition def = PolymerClassDefinition.extractFromClassNode(node, compiler);
176172
if (def != null) {
177173
PolymerClassRewriter rewriter =
178174
new PolymerClassRewriter(

test/com/google/javascript/jscomp/PolymerClassDefinitionTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ public void visit(Node node) {
185185

186186
private PolymerClassDefinition parseAndExtractClassDefFromClass(String code) {
187187
Node rootNode = compiler.parseTestCode(code);
188-
GlobalNamespace globalNamespace = new GlobalNamespace(compiler, rootNode);
189188

190189
NodeUtil.visitPostOrder(
191190
rootNode,
@@ -199,6 +198,6 @@ public void visit(Node node) {
199198
});
200199

201200
assertThat(polymerCall).isNotNull();
202-
return PolymerClassDefinition.extractFromClassNode(polymerCall, compiler, globalNamespace);
201+
return PolymerClassDefinition.extractFromClassNode(polymerCall, compiler);
203202
}
204203
}

0 commit comments

Comments
 (0)