Add TODO comments in bug-prone ASTFactory methods that create name nodes

ASTFactory create* methods depend on lifeCycleStage.isNormalized() and "$jscomp" prefix to decide name node constantess. Callsites would get a constant name depending on whether they created before or after normalize.

PiperOrigin-RevId: 602730752

Author: rishipal

src/com/google/javascript/jscomp/AstFactory.java

@@ -577,6 +577,9 @@ Node createName(String name, Type type) {
     if (lifeCycleStage.isNormalized() && name.startsWith("$jscomp")) {
       // $jscomp will always be a constant and needs to be marked that way to satisfy
       // the normalization invariants.
+      // TODO: b/322009741 - Stop depending on lifeCycleStage.isNormalized() and "$jscomp" prefix to
+      // decide constness. The callers must explicitly use `createConstantName` is they need a NAME
+      // node that's set with IS_CONSTANT_NAME prop.
       result.putBooleanProp(Node.IS_CONSTANT_NAME, true);
     }
     return result;
@@ -587,6 +590,7 @@ Node createConstantName(String name, Type type) {
     Node result = IR.name(name);
     setJSTypeOrColor(type, result);
     if (lifeCycleStage.isNormalized()) {
+      // TODO: b/322009741 - Stop depending on lifeCycleStage.isNormalized() to decide constness
       result.putBooleanProp(Node.IS_CONSTANT_NAME, true);
     }
     return result;