Mark as static effectively static inner classes

PiperOrigin-RevId: 714265520

Author: blickly

src/com/google/javascript/jscomp/Es6ExtractClasses.java

@@ -86,7 +86,7 @@ public void visit(NodeTraversal t, Node n, Node parent) {
   }
 
   private class SelfReferenceRewriter implements NodeTraversal.Callback {
-    private class ClassDescription {
+    private static class ClassDescription {
       final Node nameNode;
       final String outerName;
 

src/com/google/javascript/jscomp/Es6RewriteBlockScopedDeclaration.java

@@ -783,7 +783,7 @@ private Node createLoopObjectNameNode(LoopObject loopObject) {
       return astFactory.createName(loopObject.name, type(StandardColors.TOP_OBJECT));
     }
 
-    private class LoopObject {
+    private static class LoopObject {
 
       /**
        * The name of the variable having the loop's internal variables as properties, and the label

src/com/google/javascript/jscomp/Es6RewriteGenerators.java

@@ -1069,7 +1069,7 @@ Node findYield(Node n) {
     }
 
     /** Finds the only YIELD node in a tree. */
-    private class YieldFinder extends NodeTraversal.AbstractPreOrderCallback {
+    private static class YieldFinder extends NodeTraversal.AbstractPreOrderCallback {
 
       private Node yieldNode;
 
@@ -2205,7 +2205,7 @@ private void visitForInLoopVar(Node varDeclaration) {
       }
 
       /** Reprasents a catch case that is used by try/catch transpilation */
-      class CatchCase {
+      static class CatchCase {
         final Case catchCase;
 
         /**
@@ -2220,7 +2220,7 @@ class CatchCase {
       }
 
       /** Stores "break" and "continue" case sections assosiated with a label. */
-      class LabelCases {
+      static class LabelCases {
 
         final Case breakCase;
 

src/com/google/javascript/jscomp/InlineVariables.java

@@ -625,7 +625,7 @@ Var getAliasedVar() {
     }
 
     /** Indicates that the analyzed variable may be inlined. */
-    private class PositiveInlineVarAnalysis extends InlineVarAnalysis {
+    private static class PositiveInlineVarAnalysis extends InlineVarAnalysis {
       private final Runnable inliner;
 
       private PositiveInlineVarAnalysis(Runnable inliner) {
@@ -657,7 +657,7 @@ public boolean isSafeToInlineAliases() {
      * Indicates that the analyzed variable is an alias and the decision about whether to inline it
      * must wait until inlining has been done (or not) for the original value it aliases.
      */
-    private class VarIsAliasAnalysis extends InlineVarAnalysis {
+    private static class VarIsAliasAnalysis extends InlineVarAnalysis {
       private final Var aliasedVar;
 
       private VarIsAliasAnalysis(Var aliasedVar) {
@@ -723,7 +723,7 @@ private VarExpert createVarExpert(
     }
 
     /** Used to initialize fields in a `StandardVarExpert` object. */
-    private class VarExpertInitData {
+    private static class VarExpertInitData {
 
       Var v;
       ReferenceCollection referenceInfo;

src/com/google/javascript/jscomp/J2clPropertyInlinerPass.java

@@ -77,7 +77,7 @@ private void run() {
       new InlinePropertiesPass(result).run();
     }
 
-    private abstract class J2clProperty {
+    private abstract static class J2clProperty {
       final Node getKey;
       final Node setKey;
       boolean isSafeToInline;
@@ -382,7 +382,7 @@ void visitClass(Node classNode) {
       }
     }
 
-    private class DetermineInlinableProperties extends AbstractPostOrderCallback {
+    private static class DetermineInlinableProperties extends AbstractPostOrderCallback {
       private final Map<String, J2clProperty> propertiesByName;
 
       DetermineInlinableProperties(Map<String, J2clProperty> allGetterSetters) {

src/com/google/javascript/jscomp/ProcessCommonJSModules.java

@@ -942,7 +942,7 @@ boolean initializeModule() {
       return directAssignments < 2 && (exports.isEmpty() || moduleExports.isEmpty());
     }
 
-    private class UmdTestInfo {
+    private static class UmdTestInfo {
       public final Node enclosingIf;
       public final Node activeBranch;
 

src/com/google/javascript/jscomp/PureFunctionIdentifier.java

@@ -630,7 +630,7 @@ private final class FunctionBodyAnalyzer implements ScopedCallback {
     private final ArrayDeque<FunctionStackEntry> functionScopeStack =
         new ArrayDeque<>(ImmutableList.of(new FunctionStackEntry(null)));
 
-    final class FunctionStackEntry {
+    static final class FunctionStackEntry {
       final Node root;
       final LinkedHashSet<Var> skiplistedVars = new LinkedHashSet<>();
       final LinkedHashSet<Var> taintedVars = new LinkedHashSet<>();

src/com/google/javascript/jscomp/ReplaceCssNames.java

@@ -292,7 +292,7 @@ public SassGeneratedCssTsExpert createSassGeneratedCssTsExpert(Node n) {
           cssClosureClassesQualifiedName);
     }
 
-    private class SassGeneratedCssTsExpert {
+    private static class SassGeneratedCssTsExpert {
       public final boolean hasSassGeneratedCssTsJsDoc;
       public final JSError sassGeneratedCssTsValidationError;
       public final boolean isCssClosureClassesAssignment;
@@ -310,7 +310,7 @@ public SassGeneratedCssTsExpert(
       }
     }
 
-    private class TraversalState {
+    private static class TraversalState {
       public boolean inSassGeneratedCssTsScript;
       public String cssClosureClassesQualifiedName;
     }

src/com/google/javascript/jscomp/RescopeGlobalSymbols.java

@@ -489,7 +489,7 @@ void declareChunkGlobals() {
     }
 
     /** Variable that doesn't cross chunk boundaries. */
-    private class ChunkGlobal {
+    private static class ChunkGlobal {
       final Node root;
       final Node name;