Skip to content

Commit a21cc0f

Browse files
concavelenzcopybara-github
authored andcommitted
Delete CheckDefaultExportOfGoogModule.
This is now more of a hinderance than a benefit the TypeScript tooling will translate it to the expected pattern. PiperOrigin-RevId: 716742693
1 parent 35b2d79 commit a21cc0f

File tree

5 files changed

+0
-255
lines changed

5 files changed

+0
-255
lines changed

src/com/google/javascript/jscomp/DefaultPassConfig.java

-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import com.google.javascript.jscomp.lint.CheckArrayWithGoogObject;
4444
import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
4545
import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
46-
import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
4746
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
4847
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
4948
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -1947,7 +1946,6 @@ public void process(Node externs, Node root) {
19471946
ImmutableList.<NodeTraversal.Callback>builder()
19481947
.add(new CheckConstPrivateProperties(compiler))
19491948
.add(new CheckConstantCaseNames(compiler))
1950-
.add(new CheckDefaultExportOfGoogModule(compiler))
19511949
.add(new CheckEmptyStatements(compiler))
19521950
.add(new CheckEnums(compiler))
19531951
.add(new CheckEs6ModuleFileStructure(compiler))

src/com/google/javascript/jscomp/DiagnosticGroups.java

-3
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import com.google.javascript.jscomp.lint.CheckArrayWithGoogObject;
3333
import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
3434
import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
35-
import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
3635
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
3736
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
3837
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -555,8 +554,6 @@ public static DiagnosticGroup forName(String name) {
555554
CheckConstPrivateProperties.MISSING_CONST_PROPERTY,
556555
CheckConstantCaseNames.REASSIGNED_CONSTANT_CASE_NAME,
557556
CheckConstantCaseNames.MISSING_CONST_PROPERTY,
558-
CheckDefaultExportOfGoogModule.DEFAULT_EXPORT_IN_GOOG_MODULE,
559-
CheckDefaultExportOfGoogModule.MAYBE_ACCIDENTAL_DEFAULT_EXPORT_IN_GOOG_MODULE,
560557
CheckEmptyStatements.USELESS_EMPTY_STATEMENT,
561558
CheckEnums.COMPUTED_PROP_NAME_IN_ENUM,
562559
CheckEnums.DUPLICATE_ENUM_VALUE,

src/com/google/javascript/jscomp/LintPassConfig.java

-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import com.google.common.collect.ImmutableList;
1919
import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
2020
import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
21-
import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
2221
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
2322
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
2423
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -90,7 +89,6 @@ protected PassListBuilder getFinalizations() {
9089
ImmutableList.of(
9190
new CheckConstPrivateProperties(compiler),
9291
new CheckConstantCaseNames(compiler),
93-
new CheckDefaultExportOfGoogModule(compiler),
9492
new CheckDuplicateCase(compiler),
9593
new CheckEmptyStatements(compiler),
9694
new CheckEnums(compiler),

src/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModule.java

-132
This file was deleted.

test/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModuleTest.java

-116
This file was deleted.

0 commit comments

Comments
 (0)