Disable UnreachableCodeElimination pass

PiperOrigin-RevId: 633963346

Author: Closure Team

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -985,10 +985,6 @@ private PassListBuilder getEarlyOptimizationLoopPasses() {
       earlyLoopPasses.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeUnreachableCode) {
-      earlyLoopPasses.maybeAdd(removeUnreachableCode);
-    }
-
     earlyLoopPasses.assertAllLoopablePasses();
     return earlyLoopPasses;
   }
@@ -1060,9 +1056,6 @@ private PassListBuilder getPostL10nOptimizations() {
       loopPasses.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeUnreachableCode) {
-      loopPasses.maybeAdd(removeUnreachableCode);
-    }
     loopPasses.assertAllLoopablePasses();
     return loopPasses;
   }
@@ -1129,9 +1122,6 @@ private PassListBuilder getMainOptimizationLoop() {
       passes.maybeAdd(peepholeOptimizations);
     }
 
-    if (options.removeUnreachableCode) {
-      passes.maybeAdd(removeUnreachableCode);
-    }
 
     passes.assertAllLoopablePasses();
     return passes;
@@ -2266,14 +2256,6 @@ public void process(Node externs, Node root) {
               (compiler) -> new InlineVariables(compiler, InlineVariables.Mode.CONSTANTS_ONLY))
           .build();
 
-  /** Use data flow analysis to remove dead branches. */
-  private final PassFactory removeUnreachableCode =
-      PassFactory.builder()
-          .setName(PassNames.REMOVE_UNREACHABLE_CODE)
-          .setRunInFixedPointLoop(true)
-          .setInternalFactory(UnreachableCodeElimination::new)
-          .build();
-
   /** Inlines simple methods, like getters */
   private final PassFactory inlineSimpleMethods =
       PassFactory.builder()

test/com/google/javascript/jscomp/MultiPassTest.java

@@ -90,7 +90,7 @@ public void testInlineFunctionsAndPeephole() {
   public void testInlineVarsAndDeadCodeElim() {
     passes = new ArrayList<>();
     addInlineVariables();
-    addDeadCodeElimination();
+    addPeephole();
     test("function f() { var x = 1; return x; x = 3; }", "function f() { return 1; }");
   }
 
@@ -390,15 +390,6 @@ private void addCollapseObjectLiterals() {
             .build());
   }
 
-  private void addDeadCodeElimination() {
-    passes.add(
-        PassFactory.builder()
-            .setName("removeUnreachableCode")
-            .setRunInFixedPointLoop(true)
-            .setInternalFactory(UnreachableCodeElimination::new)
-            .build());
-  }
-
   private void addInlineFunctions() {
     passes.add(
         PassFactory.builder()

test/com/google/javascript/jscomp/integration/AdvancedOptimizationsIntegrationTest.java

@@ -99,7 +99,20 @@ public void testObjectDestructuring_forLoopInitializer_doesNotCrash() {
             "      $jscomp$loop$98447280$2.key = path.key;",
             "      return path;",
             "    };",
-            "   }($jscomp$loop$98447280$2)(); $jscomp$loop$98447280$2.parentPath;) {",
+            "  }($jscomp$loop$98447280$2)();",
+            "  $jscomp$loop$98447280$2.parentPath;",
+            "  $jscomp$loop$98447280$2 = {",
+            "    parentPath:$jscomp$loop$98447280$2.parentPath,",
+            "    key:$jscomp$loop$98447280$2.key",
+            "  },",
+            "  function($jscomp$loop$98447280$2) { ",
+            "    return function() { ",
+            "      var $jscomp$destructuring$var3 = $jscomp$loop$98447280$2.parentPath; ",
+            "      $jscomp$loop$98447280$2.parentPath = $jscomp$destructuring$var3.parentPath; ",
+            "      $jscomp$loop$98447280$2.key = $jscomp$destructuring$var3.key; ",
+            "      return $jscomp$destructuring$var3; ",
+            "    }; ",
+            "  }($jscomp$loop$98447280$2)()) {",
             "    return isDeclaredInLoop($jscomp$loop$98447280$2.parentPath);",
             "   }",
             "  return !1;",

test/com/google/javascript/jscomp/integration/IntegrationTest.java

@@ -1531,7 +1531,7 @@ public void testDisambiguatePropertiesWithPropertyInvalidationError() {
   public void testMarkPureCalls() {
     String testCode = "function foo() {} foo();";
     CompilerOptions options = createCompilerOptions();
-    options.setRemoveUnreachableCode(true);
+    options.setFoldConstants(true);
 
     testSame(options, testCode);
 
@@ -1748,7 +1748,7 @@ public void testRemoveUnreachableCode() {
     String code = "function f() { return; f(); }";
     testSame(options, code);
 
-    options.setRemoveUnreachableCode(true);
+    options.setFoldConstants(true);
     test(options, code, "function f() {}");
   }