Remove support for goog.defineClass in favor of ES Class syntax or traditional ES5 style classes.

PiperOrigin-RevId: 722803069

Author: concavelenz

src/com/google/javascript/jscomp/CheckJSDoc.java

@@ -227,9 +227,7 @@ private void validateTypedefs(Node n, JSDocInfo info) {
       return;
     }
     Node lvalue = NodeUtil.isNameDeclaration(n) || n.isAssign() ? n.getFirstChild() : n;
-    // Static properties for goog.defineClass are rewritten to qualified names before typechecking
-    // runs and are valid as @typedefs.
-    if (!lvalue.isQualifiedName() && !isGoogDefineClassStatic(lvalue)) {
+    if (!lvalue.isQualifiedName()) {
       reportMisplaced(
           n,
           "typedef",
@@ -242,14 +240,6 @@ private void validateTypedefs(Node n, JSDocInfo info) {
     }
   }
 
-  /** Whether this is a property in this object: {@code goog.defineClass(superClass, {statics: {} */
-  private boolean isGoogDefineClassStatic(Node n) {
-    return n.isStringKey()
-        && n.getParent().isObjectLit()
-        && n.getGrandparent().isStringKey()
-        && n.getGrandparent().getString().equals("statics");
-  }
-
   private void validateTemplates(Node n, JSDocInfo info) {
     if (info != null
         && !info.getTemplateTypeNames().isEmpty()
@@ -286,13 +276,6 @@ && getFunctionDecl(n) == null) {
       return n.getLastChild();
     }
 
-    if (n.isStringKey()
-        && n.getGrandparent() != null
-        && ClosureRewriteClass.isGoogDefineClass(n.getGrandparent())
-        && n.getFirstChild().isFunction()) {
-      return n.getFirstChild();
-    }
-
     if (n.isGetterDef() || n.isSetterDef()) {
       return n.getFirstChild();
     }
@@ -389,13 +372,8 @@ private void validateAbstractJsDoc(Node n, JSDocInfo info) {
       return;
     }
 
-    // TODO(b/124020008): Delete this case when `goog.defineClass` is dropped.
-    boolean isGoogDefineClassConstructor =
-        n.getParent().isObjectLit()
-            && (n.isMemberFunctionDef() || n.isStringKey())
-            && "constructor".equals(n.getString());
-    if (NodeUtil.isEs6ConstructorMemberFunctionDef(n) || isGoogDefineClassConstructor) {
-      // @abstract annotation on an ES6 or goog.defineClass constructor
+    if (NodeUtil.isEs6ConstructorMemberFunctionDef(n)) {
+      // @abstract annotation on an ES6 constructor
       report(n, MISPLACED_ANNOTATION, "@abstract", "constructors cannot be abstract");
       return;
     }

src/com/google/javascript/jscomp/ClosureCodingConvention.java

@@ -136,13 +136,6 @@ public void applySubclassRelationship(
     return null;
   }
 
-  private static final QualifiedName GOOG_DEFINECLASS = QualifiedName.of("goog.defineClass");
-
-  @Override
-  public boolean isClassFactoryCall(Node callNode) {
-    return GOOG_DEFINECLASS.matches(callNode.getFirstChild());
-  }
-
   /**
    * Determines whether the given node is a class-defining name, like "inherits" or "mixin."
    *