Get rid of unnecessary anonymous classes

These can generally be replaced with functions or inlined completely.

PiperOrigin-RevId: 601809673

Author: blickly

src/com/google/javascript/jscomp/ConformanceRules.java

@@ -588,17 +588,14 @@ static final class BannedName extends AbstractRule {
     }
 
     private static final Precondition IS_CANDIDATE_NODE =
-        new Precondition() {
-          @Override
-          public boolean shouldCheck(Node n) {
-            switch (n.getToken()) {
-              case GETPROP:
-                return n.getFirstChild().isQualifiedName();
-              case NAME:
-                return !n.getString().isEmpty();
-              default:
-                return false;
-            }
+        (Node n) -> {
+          switch (n.getToken()) {
+            case GETPROP:
+              return n.getFirstChild().isQualifiedName();
+            case NAME:
+              return !n.getString().isEmpty();
+            default:
+              return false;
           }
         };
 
@@ -1953,17 +1950,10 @@ protected ConformanceResult checkConformance(NodeTraversal t, Node n) {
       return ConformanceResult.CONFORMANCE;
     }
 
-    private static final Precondition IS_SCRIPT_NODE =
-        new Precondition() {
-          @Override
-          public boolean shouldCheck(Node n) {
-            return n.isScript();
-          }
-        };
 
     @Override
     public final Precondition getPrecondition() {
-      return IS_SCRIPT_NODE;
+      return Node::isScript;
     }
   }
 
@@ -1996,17 +1986,10 @@ protected ConformanceResult checkConformance(NodeTraversal t, Node n) {
       return ConformanceResult.CONFORMANCE;
     }
 
-    private static final Precondition IS_SCRIPT_NODE =
-        new Precondition() {
-          @Override
-          public boolean shouldCheck(Node n) {
-            return n.isScript();
-          }
-        };
 
     @Override
     public final Precondition getPrecondition() {
-      return IS_SCRIPT_NODE;
+      return Node::isScript;
     }
   }
 

src/com/google/javascript/jscomp/Es6RewriteBlockScopedDeclaration.java

@@ -129,12 +129,7 @@ private boolean inLoop(Node n) {
   }
 
   private static final Predicate<Node> isLoopOrFunction =
-      new Predicate<Node>() {
-        @Override
-        public boolean apply(Node n) {
-          return n.isFunction() || NodeUtil.isLoopStructure(n);
-        }
-      };
+      (n) -> n.isFunction() || NodeUtil.isLoopStructure(n);
 
   private static void extractInlineJSDoc(Node srcDeclaration, Node srcName, Node destDeclaration) {
     JSDocInfo existingInfo = srcDeclaration.getJSDocInfo();

src/com/google/javascript/jscomp/RenameVars.java

@@ -292,21 +292,17 @@ void incCount(String name) {
   }
 
   /**
-   * Sorts Assignment objects by their count, breaking ties by their order of
-   * occurrence in the source to ensure a deterministic total ordering.
+   * Sorts Assignment objects by their count, breaking ties by their order of occurrence in the
+   * source to ensure a deterministic total ordering.
    */
-  private static final Comparator<Assignment> FREQUENCY_COMPARATOR =
-      new Comparator<Assignment>() {
-    @Override
-    public int compare(Assignment a1, Assignment a2) {
-      if (a1.count != a2.count) {
-        return a2.count - a1.count;
-      }
-      // Break a tie using the order in which the variable first appears in
-      // the source.
-      return ORDER_OF_OCCURRENCE_COMPARATOR.compare(a1, a2);
+  private static int frequencyComparator(Assignment a1, Assignment a2) {
+    if (a1.count != a2.count) {
+      return a2.count - a1.count;
     }
-  };
+    // Break a tie using the order in which the variable first appears in
+    // the source.
+    return ORDER_OF_OCCURRENCE_COMPARATOR.compare(a1, a2);
+  }
 
   /** Sorts Assignment objects by the order the variable name first appears in the source. */
   private static final Comparator<Assignment> ORDER_OF_OCCURRENCE_COMPARATOR =
@@ -325,7 +321,7 @@ public void process(Node externs, Node root) {
     reservedNames.addAll(externNames);
 
     // Rename vars, sorted by frequency of occurrence to minimize code size.
-    SortedSet<Assignment> varsByFrequency = new TreeSet<>(FREQUENCY_COMPARATOR);
+    SortedSet<Assignment> varsByFrequency = new TreeSet<>(RenameVars::frequencyComparator);
     varsByFrequency.addAll(assignments.values());
 
     // First try to reuse names from an earlier compilation.

src/com/google/javascript/jscomp/Xid.java

@@ -51,14 +51,8 @@ public interface HashFunction {
     int hashCode(String value);
   }
 
-  private static final HashFunction DEFAULT = new HashFunction() {
-    @Override public int hashCode(String value) {
-      return value.hashCode();
-    }
-  };
-
   public Xid() {
-    this.hasher = DEFAULT;
+    this.hasher = String::hashCode;
   }
 
   public Xid(HashFunction hasher) {