Skip to content

Commit f51970c

Browse files
committed
Clean up now unnecessary @GwtIncompatible from JSCompiler codebase
PiperOrigin-RevId: 707232778
1 parent 8c58281 commit f51970c

File tree

4 files changed

+1
-12
lines changed

4 files changed

+1
-12
lines changed

src/com/google/javascript/rhino/JSIdentifier.java

-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545

4646
package com.google.javascript.rhino;
4747

48-
import com.google.common.annotations.GwtIncompatible;
4948

5049
/**
5150
* Utility class to hold isJSIdentifier.
@@ -55,7 +54,6 @@
5554
* <p>IMPORTANT: As of 2018-03-09 it is still not possible to use Java 8 features in this file due
5655
* to limitations on some internal Google projects that depend on it.
5756
*/
58-
@GwtIncompatible
5957
public final class JSIdentifier {
6058
static boolean isJSIdentifier(String s) {
6159
int length = s.length();

src/com/google/javascript/rhino/Node.java

-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import static com.google.common.base.Preconditions.checkState;
4646
import static com.google.javascript.jscomp.base.JSCompDoubles.isPositive;
4747

48-
import com.google.common.annotations.GwtIncompatible;
4948
import com.google.common.annotations.VisibleForTesting;
5049
import com.google.common.base.Ascii;
5150
import com.google.common.collect.ImmutableMap;
@@ -2498,7 +2497,6 @@ public final boolean isValidAssignmentTarget() {
24982497
}
24992498

25002499
@DoNotCall
2501-
@GwtIncompatible
25022500
@Override
25032501
public final Object clone() {
25042502
throw new UnsupportedOperationException("Did you mean cloneNode?");

src/com/google/javascript/rhino/TokenUtil.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,12 @@
4545

4646
package com.google.javascript.rhino;
4747

48-
import com.google.common.annotations.GwtIncompatible;
4948
import com.google.javascript.jscomp.base.Tri;
5049

5150
/**
52-
* Helper methods for parsing JavaScript. These methods use unsupported features in GWT's emulation
53-
* of java.lang.Character.
54-
*
55-
* <p>TODO(moz): Add a GWT-compatible version in the super-source directory.
51+
* Helper methods for parsing JavaScript.
5652
*
5753
*/
58-
@GwtIncompatible("Unsupported java.lang.Character fields")
5954
public final class TokenUtil {
6055
/* As defined in ECMA. jsscan.c uses C isspace() (which allows
6156
* \v, I think.) note that code in getChar() implicitly accepts

src/com/google/javascript/rhino/dtoa/DToA.java

-2
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,8 @@
5858
***************************************************************/
5959
package com.google.javascript.rhino.dtoa;
6060

61-
import com.google.common.annotations.GwtIncompatible;
6261
import java.math.BigInteger;
6362

64-
@GwtIncompatible("unnecessarily complex")
6563
public final class DToA {
6664

6765
private static final int

0 commit comments

Comments
 (0)