Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not respond with VN packet to received VN packet #75

Open
slusnys opened this issue Sep 13, 2024 · 0 comments
Open

Do not respond with VN packet to received VN packet #75

slusnys opened this issue Sep 13, 2024 · 0 comments

Comments

@slusnys
Copy link

slusnys commented Sep 13, 2024

RFC says: An endpoint MUST NOT send a Version Negotiation packet in response to receiving a Version Negotiation packet.
QUICHE currently does not check this. This is an important mechanism to prevent looping.

It should be enough to do this in QuicDispatcher::MaybeSendVersionNegotiationPacket:

if (packet_info.form == IETF_QUIC_LONG_HEADER_PACKET
&& packet_info.long_packet_type == QuicLongHeaderType::VERSION_NEGOTIATION) {
QUIC_DVLOG(1) << "Dropping the received VN packet without response.";
return;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant