Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopassbridge prompting me to update gopass despite having newer version #224

Open
skewballfox opened this issue May 24, 2022 · 6 comments
Open

Comments

@skewballfox
Copy link

something seems to be messing up with this function

when I open gopassbridge, instead of showing my suggested passwords, I'm prompted to update gopass:

Please update gopass to version 1.8.5 or newer.

however I'm currently on gopass 1.14.1.

let me know if you need anything else

@jwmurraycell
Copy link

I think I might have a simple solution if you're also experiencing this issue with the version that's currently available in the Fedora repos. I uninstalled that version and downloaded the rpm from the Github releases page, installed it, and ran the configure option again. After that the extension in Firefox no longer tells me that gopass need to be newerd than 1.8.5

@tennox
Copy link

tennox commented Jun 16, 2022

Thanks for the suggestion - but I've tried that (now gopass 1.14.3 go1.18.2 linux amd64), re-ran gopass-jsonapi configure, and restarted firefox - but still get the same error.

I have then did the same thing for gopass-jsonapi itself, and now it works 👍
(weirdly, dnf said Downgrade to gopass-jsonapi-1.11.1-1.x86_64)

@skewballfox
Copy link
Author

so this is an issue with the version of gopass-jsonapi provided in the fedora repositories? should I submit a bug report asking them to upgrade that package specifically?

@isodude
Copy link

isodude commented Aug 24, 2022

A nice way to debug this would be to modify the gopass-bridge.sh accordingly:

--- gopass_wrapper.sh	2022-08-25 00:39:31.368000000 +0200
+++ gopass_wrapper.sh	2022-08-25 00:40:09.696000000 +0200
@@ -10,6 +10,6 @@ fi
 export PATH="$PATH:/usr/local/bin" # required on MacOS/brew
 export GPG_TTY="$(tty)"
 
-gopass-jsonapi listen
+tee -a /tmp/gopass-in | gopass-jsonapi listen | tee -a /tmp/gopass-out
 
 exit $?

Use hexdump -C on /tmp/gopass-in vs /tmp/gopass-out.

Most likely getVersion is messed up.

@isodude
Copy link

isodude commented Aug 24, 2022

Oh, and it's probably related to gopasspw/gopass-jsonapi#2 ?

@lkiesow
Copy link

lkiesow commented Jul 5, 2023

@isodude made me think of a workaround. You can just patch the result of getVersion in the wrapper script:

-gopass-jsonapi listen
+gopass-jsonapi listen | sed 's_version":"0.0.0","major":0,"minor":0,"patch":0_version":"1.8.5","major":1,"minor":8,"patch":5_'

But looking at this I would suspect a packaging issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants