Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rggb12p pixel format issues #16

Open
schoolpost opened this issue Apr 6, 2019 · 4 comments
Open

rggb12p pixel format issues #16

schoolpost opened this issue Apr 6, 2019 · 4 comments

Comments

@schoolpost
Copy link

schoolpost commented Apr 6, 2019

Has this been verified working? if so what format does it expect for a RAW input file?

I've created a 12bit packed byte array and all my outputs have tons of artifacting due to what I imagine is incorrect demosaicing?

my camera's bayer sensor is BGGR so its flipped to match the expected input of RGGB.

It's 3280 x 2464 packed at 12bpp

I can verify my output is correct when I view the same byte array within a custom encoded dng
sample.zip

@dnewman-gpsw
Copy link
Collaborator

I have confirmed your findings, checking to find what is wrong.

@adeelabbas
Copy link

gpr_tools supports following formats: rggb12, rggb12p, [rggb14], gbrg12, gbrg12p. Your camera's format is bggr12p (where p is for packed), which is not supported at the moment.

You could do a flip offline and then feed flipped image to gpr_tools to see if that works.

@dnewman-gpsw
Copy link
Collaborator

I'm looking into add the missing formats at the moment.

@schoolpost
Copy link
Author

gpr_tools supports following formats: rggb12, rggb12p, [rggb14], gbrg12, gbrg12p. Your camera's format is bggr12p (where p is for packed), which is not supported at the moment.

You could do a flip offline and then feed flipped image to gpr_tools to see if that works.

I'm actually already doing this flip, but even so there seems to be something wrong with the output when open in a RAW viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants