remotecfg: success metric not updated properly in case of a NotModified response

[tpaschalis]

What's wrong?

alloy/internal/service/remotecfg/remotecfg.go

Line 383 in 1278fcb

if err == nil || err == errNotModified {

The following check means that when we get a NotModified response, we keep the success metric as true.

cc @spartan0x117 was there a rationale that I may be missing here?

Steps to reproduce

Use remotecfg, wait for a few loops with a bad configuration, see the metric reported as 1

System information

No response

Software version

No response

Configuration

Logs