Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LZ4 content encoding in the OTEL receiver once supported #9259

Closed
irisgve opened this issue Sep 10, 2024 · 13 comments · Fixed by #9763
Closed

Support LZ4 content encoding in the OTEL receiver once supported #9259

irisgve opened this issue Sep 10, 2024 · 13 comments · Fixed by #9763
Assignees
Labels
area/opentelemetry enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@irisgve
Copy link
Contributor

irisgve commented Sep 10, 2024

Is your feature request related to a problem? Please describe.

This PR adds LZ4 encoding in the OTLP exporters. Once merged, it'll be great if we can support it in the distributor as well.

Describe the solution you'd like

Add LZ4 support here

Happy to submit a PR to support this.

@56quarters 56quarters added enhancement New feature or request area/opentelemetry labels Oct 7, 2024
@ying-jeanne
Copy link
Contributor

ying-jeanne commented Oct 15, 2024

It is a good idea @irisgve, PR is welcomed! (: Happy to review when it is done.

@ying-jeanne ying-jeanne added the help wanted Extra attention is needed label Oct 15, 2024
@armandgrillet armandgrillet added the good first issue Good for newcomers label Oct 25, 2024
@santileira
Copy link
Contributor

@irisgve / @ying-jeanne / @armandgrillet is this "issue" still opened? If so, I can get a PR ready to support LZ4 on the distributor.

@armandgrillet
Copy link
Contributor

@santileira Yes the issue is still open, feel free to contribute with a PR.

@santileira
Copy link
Contributor

@armandgrillet makes sense. Could you assign it to me? Thanks

@santileira
Copy link
Contributor

@armandgrillet here is the PR: #9763 but for some reason the GitHub actions are not running. Do you know why?

@armandgrillet
Copy link
Contributor

The CI needed to be approved by a contributor for it to run, I have 👍 it.

@aknuds1
Copy link
Contributor

aknuds1 commented Oct 29, 2024

@irisgve could you provide any context on why one would use LZ4 over e.g. Snappy (Mimir supports Snappy for gRPC compression, as a data point)?

@santileira
Copy link
Contributor

@irisgve could you review the question from @aknuds1 and provide an answer? I would like to understand if we can move forward with the PR. Thanks

@irisgve
Copy link
Contributor Author

irisgve commented Nov 4, 2024

Hey @aknuds1 @santileira internally we've found significant (data transfer costs) savings and performance improvements on implementing LZ4 compression in our metrics pipelines. It has slightly better compression ratios than snappy i.e. some benchmarks on https://github.com/inikep/lzbench/blob/master/lzbench18_sorted.md

@aknuds1
Copy link
Contributor

aknuds1 commented Nov 5, 2024

Thanks @irisgve.

@santileira
Copy link
Contributor

Closed. We merged the PR. Thanks!

@pjastrzabek
Copy link

@irisgve We switched to gzip due to data transfer costs (especially cross AZ). Have you possibly tested gzip? If yes, How did it compare with LZ4?

@irisgve
Copy link
Contributor Author

irisgve commented Jan 15, 2025

Hi @pjastrzabek while gzip had better compression ratios (potentially lower data transfer costs) lz4 is ~10x faster than gzip and has lower CPU usage during compression/decompression which is more ideal for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opentelemetry enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants