-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LZ4 content encoding in the OTEL receiver once supported #9259
Comments
It is a good idea @irisgve, PR is welcomed! (: Happy to review when it is done. |
@irisgve / @ying-jeanne / @armandgrillet is this "issue" still opened? If so, I can get a PR ready to support LZ4 on the distributor. |
@santileira Yes the issue is still open, feel free to contribute with a PR. |
@armandgrillet makes sense. Could you assign it to me? Thanks |
@armandgrillet here is the PR: #9763 but for some reason the GitHub actions are not running. Do you know why? |
The CI needed to be approved by a contributor for it to run, I have 👍 it. |
@irisgve could you provide any context on why one would use LZ4 over e.g. Snappy (Mimir supports Snappy for gRPC compression, as a data point)? |
Hey @aknuds1 @santileira internally we've found significant (data transfer costs) savings and performance improvements on implementing LZ4 compression in our metrics pipelines. It has slightly better compression ratios than snappy i.e. some benchmarks on https://github.com/inikep/lzbench/blob/master/lzbench18_sorted.md |
Thanks @irisgve. |
Closed. We merged the PR. Thanks! |
@irisgve We switched to gzip due to data transfer costs (especially cross AZ). Have you possibly tested gzip? If yes, How did it compare with LZ4? |
Hi @pjastrzabek while gzip had better compression ratios (potentially lower data transfer costs) lz4 is ~10x faster than gzip and has lower CPU usage during compression/decompression which is more ideal for us. |
Is your feature request related to a problem? Please describe.
This PR adds LZ4 encoding in the OTLP exporters. Once merged, it'll be great if we can support it in the distributor as well.
Describe the solution you'd like
Add LZ4 support here
Happy to submit a PR to support this.
The text was updated successfully, but these errors were encountered: