Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metric to keep track of the discarded samples #3959

Open
kolesnikovae opened this issue Feb 28, 2025 · 0 comments
Open

Add a metric to keep track of the discarded samples #3959

kolesnikovae opened this issue Feb 28, 2025 · 0 comments
Assignees
@kolesnikovae
Labels
enhancement New feature or request

Comments

@kolesnikovae
Copy link
Collaborator

When a profile is ingested, Pyroscope discards invalid stack trace samples in Normalize. It would be useful to track these discarded samples as a metric.

We already have pyroscope_discarded_bytes_total and pyroscope_discarded_samples_total which are updated when an entire profile is rejected (e.g., due to an invalid profile, a limit violation, or a relabel rule).

See #3955 (comment)
@kolesnikovae kolesnikovae added the enhancement New feature or request label Feb 28, 2025
@kolesnikovae kolesnikovae self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolesnikovae kolesnikovae

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kolesnikovae