Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Fixes and Tests #1907

Merged

Conversation

dsblank
Copy link
Member

@dsblank dsblank commented Feb 1, 2025

This PR is on #1876 to fix and test proxies.

@dsblank dsblank marked this pull request as ready for review February 1, 2025 18:53
@dsblank
Copy link
Member Author

dsblank commented Feb 1, 2025

@stevenyoungs, @Nick-Hall: let me know if you want me to merge this in to #1876 ... it needs those methods, but I don't want to add things at the last minute unless you are ok with it.

@stevenyoungs
Copy link
Contributor

@dsblank having briefly looked at the non-test changes, I'd be in favour of merging into #1876.

@Nick-Hall
Copy link
Member

@dsblank Yes. Please merge into #1876.

I plan to review and merge both #1794 and #1876 tomorrow.

@dsblank dsblank merged commit 3d13f52 into dsb/use-orjson-plus-encoder Feb 1, 2025
2 checks passed
@dsblank dsblank deleted the dsb/use_orjson_plus_encode_proxy_fixes branch February 1, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants