Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default toolbar style option and replace it with "Both" #1973

Merged

Conversation

Nick-Hall
Copy link
Member

@Nick-Hall Nick-Hall commented Feb 14, 2025

The "Use default preference" option has been removed because it was confusing users. Using a system desktop default also doesn't make much sense since the Toolbar widget has been removed in Gtk4.

The default of "Both text and icons" is intended to be helpful for new users.

@Nick-Hall Nick-Hall added this to the v6.0 milestone Feb 14, 2025
@lordemannd
Copy link
Contributor

works for me, with 1 quibble.
for me, after adding this PR, on the Preferences->General Tab, the initial condition of the field was blank.
can't say if that is confusing for new users, the blank field probably is understood to mean 'no attention required'

is it possible to initialize the value to one of the 3 values?

@Nick-Hall
Copy link
Member Author

Nick-Hall commented Feb 14, 2025

@lordemannd Please delete your gramps.ini file and try again.

The problem is that you had toolbar-style set to 3, which is no longer possible. The default is 0 (Both text and icons).

For upgrading users this won't be a problem. For beta testers with the value set to 3, it will display an empty choice in the preferences and the buttons will display only icons instead of both icons and text. Just choose another option and continue.

@emyoulation
Copy link
Contributor

emyoulation commented Feb 14, 2025

The Zeroth option used to be the defaults in beta1 and Beta2

That '0' problem (now that it is not an option) only ever affect beta testers.

So it is an error condition that shouldn't need handling.

The "Use default preference" option has been removed because it was
confusing users. Using a system desktop default also doesn't make
much sense since the Toolbar widget has been removed in Gtk4.

The default of "Both text and icons" is intended to be helpful for
new users.
@Nick-Hall Nick-Hall merged commit c5e38ee into gramps-project:maintenance/gramps60 Feb 14, 2025
2 checks passed
@Nick-Hall Nick-Hall deleted the toolbar-style branch February 14, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants