-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
searchPagination won't work in ES > 7.0 #96
Comments
pcasa
added a commit
to pcasa/graphql-compose-elasticsearch
that referenced
this issue
Sep 16, 2020
@nodkz added a PR, I had a similar need. |
pcasa
added a commit
to pcasa/graphql-compose-elasticsearch
that referenced
this issue
Sep 16, 2020
pcasa
added a commit
to pcasa/graphql-compose-elasticsearch
that referenced
this issue
Sep 16, 2020
pcasa
added a commit
to pcasa/graphql-compose-elasticsearch
that referenced
this issue
Sep 16, 2020
nodkz
pushed a commit
that referenced
this issue
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is breaking change in total hits so now graphql generates error:
I think this should be checked if it is object:
Here is link to this breaking change:
https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking-changes-7.0.html#hits-total-now-object-search-response
I think
itemCount
could be changed to something like this:Unfortunately this won't work if
hits_total
will be greater than 1000.So maybe it would be better to set
track_total_hits
totrue
The text was updated successfully, but these errors were encountered: