"defineObjectType" from $Types and what I found I during the creation of it. #19
Replies: 1 comment 3 replies
-
Thanks for this feedback!
This is done now thanks to @lvauvillier
To go further on this please open an issue with examples showing why this is a better DX in multiple use-cases.
It is optimized for the doc experience of writing code and working in-context at call sites. Not particularly for opening the generated runtime module. Again to go further on this please open an issue with examples showing why this is a better DX in multiple use-cases with another approach. I think it might make sense to allow documentation to be disabled, as a simple boolean flag.
Its not expected that errors can happen so issue welcome! |
Beta Was this translation helpful? Give feedback.
-
Schema
Function with types (fully working types! 😮)
My feelings on this
Invalid index.d.ts (in
node_modules/nexus-prisma/dist/runtime
)This is probably referring to current midterms (19.3.2021)
Error:
Naming
Cart.$name
vsCart.field.name
,type
anddescription
, it is unexpected to say the least. I would propose to useSymbol
supported from nodeJS 6.4. It would prevent collision if someone would name their column$name
, which might happen...Type of
$description
should bestring | undefined
Rather than
string | null
,$description
should bestring | undefined
. It would allow being mapped directly toobjectType.description.
Automatic comments
Description of just two tables above spans across 854 lines!. If the description of
name
anddescription
would be single-line it would result in 144 lines. Much more readable.Beta Was this translation helpful? Give feedback.
All reactions