Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align address/cluster field names #11

Open
myrho opened this issue Apr 27, 2021 · 7 comments
Open

Align address/cluster field names #11

myrho opened this issue Apr 27, 2021 · 7 comments
Assignees

Comments

@myrho
Copy link

myrho commented Apr 27, 2021

I'd suggest to align address and cluster field names where they mean the same:

  • relation tables: value <> estimated_value
  • id fields: address_id <> cluster resp. address_id_group <> cluster_group (better: cluster_id and cluster_id_group)
@myrho
Copy link
Author

myrho commented Apr 27, 2021

eth:

  • raw.block.block_group <> transformed.block_transactions.height_group
  • raw.block.number <> transformed.block_transactions.height <> raw.transaction.block_number

@myrho
Copy link
Author

myrho commented Apr 29, 2021

Just collecting things here. Need to discuss:

  • block_transactions.txs (a list) <> address_transactions.transaction_id (a foreign key)

@myrho
Copy link
Author

myrho commented May 7, 2021

cluster_tag_by_label column entity instead of cluster

@mdragaschnig
Copy link
Member

Updated eth_raw graphsense/graphsense-ethereum-etl@3e3065e

defconst referenced this issue in graphsense/graphsense-transformation Jul 2, 2021
See also: #41
@myrho
Copy link
Author

myrho commented Aug 5, 2021

utxo transformed schema:

CREATE TYPE tx_id_time (
    block_id int,
    tx_id bigint,
    timestamp int
);

vs. eth transformed schema:

CREATE TYPE tx_id_time (
    height int,
    transaction_id int,
    block_timestamp int
);

Please align if possible. (see next comment)

@myrho
Copy link
Author

myrho commented Aug 5, 2021

I think we can remove tx_id_time at all since tx needs to be looked up anyways for the tx_hash. Instead just store tx_id for first/last_tx in address/cluster table.

@myrho
Copy link
Author

myrho commented Aug 5, 2021

address_transactions: timestamp and block_id could be removed also (like in the eth transformation).

defconst referenced this issue in graphsense/graphsense-transformation Aug 16, 2021
Columns `block_id` and `timestamp` not used in graphsense-rest and
therefore removed from Cassandra schema.

See #41
defconst referenced this issue in graphsense/graphsense-transformation Aug 16, 2021
Remove unused field `timestamp` (not used in graphsense-rest).

See #41
defconst referenced this issue Aug 18, 2021
- rename height to block_id
- remove tx_id_time struct column, just store tx id

See also: #3, graphsense/graphsense-transformation#41
@soad003 soad003 transferred this issue from graphsense/graphsense-transformation Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants